Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot open document: "Open" button does not work #322

Closed
dizzzz opened this issue Jul 5, 2021 · 2 comments
Closed

[BUG] Cannot open document: "Open" button does not work #322

dizzzz opened this issue Jul 5, 2021 · 2 comments
Assignees
Labels

Comments

@dizzzz
Copy link
Member

dizzzz commented Jul 5, 2021

Scenario NOK:

  • select document
  • click "Open" (red)
  • 404

Scenario OK:

  • double click document (blue)

image

@joewiz
Copy link
Member

joewiz commented Jul 5, 2021

I can confirm this bug with eXist 5.3.0 and eXide 3.0.0 in Chrome 91.0.4472.114 on macOS 11.4. You have to use the "open" button rather than double-clicking on a resource's row.

eXide will trigger an HTTP GET request to http://localhost:8080/exist/apps/eXide/modules/load.xql?path=undefined, returning a 404.

The expected URL is http://localhost:8080/exist/apps/eXide/modules/load.xql?path=/db/apps/demo/build.xml.

I think the relevant code is somewhere here: https://github.com/eXist-db/eXide/blob/develop/src/eXide.js#L273-L327. The code was recently touched in this commit: c4821f0.

@TeddyBoomer
Copy link
Contributor

TeddyBoomer commented Aug 19, 2021

Hi, I would like to point out a hint(?) about this problem but I'm rather newbie on js:
in https://github.com/eXist-db/eXide/blob/develop/src/resources.js#L155:
there is a call in a .api attribute while it's undefined above at L147-152; and then the button can't grab the right data, while onRowDoubleClicked is ok just after at L163.

(12/09/2021)
Hi, ok -1 for me: I got into ag-grid some times ago, for the .api.
Coming back to joewitz https://github.com/eXist-db/eXide/blob/develop/src/eXide.js#L273-L327.
I think the "open" definition of the button is pretty strange: openSelectedDocument is a 2 params function
for a click (no params), maybe:
"open": function() { openSelectedDocument(null, false);}
would be better at L278 (still don't know why it would work before with only one param)

@joewiz joewiz closed this as completed in 4fff542 Oct 13, 2021
joewiz added a commit that referenced this issue Oct 13, 2021
fix eXide #322. seems to work fine after compile and load in the app-…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants