Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File/Manage/Upload and Cut/Copy/Paste #225

Merged
merged 1 commit into from Aug 30, 2019
Merged

Fix File/Manage/Upload and Cut/Copy/Paste #225

merged 1 commit into from Aug 30, 2019

Conversation

RemiKoutcherawy
Copy link
Contributor

@RemiKoutcherawy RemiKoutcherawy commented Aug 6, 2019

With eXide, select File > Manage, then:

  • Upload A.xml to /db/apps
  • Click Done
  • Goto /db
  • Upload A.xml to /db
  • Click Done

--> Bug: A.xml is not in /db

  • Select A.xml in /db/apps
  • Click Cut (Scissors)
  • Click Copy (Left of scissors)
  • Goto /db/apps
  • Click Paste
  • Goto /db

--> Bug: A.xml is not in /db

I hope this will be merged in next release.

@joewiz
Copy link
Member

joewiz commented Aug 6, 2019

Could you please rebase?

@RemiKoutcherawy
Copy link
Contributor Author

RemiKoutcherawy commented Aug 6, 2019

There is only one file modified: src/resources.js
Not sure how to rebase, I did:

$ git branch -u upstream/develop
$ git rebase 
$ git rebase --skip
$ git branch -u origin/develop
$ git push --force

to squash commits.

@joewiz
Copy link
Member

joewiz commented Aug 8, 2019

Ok, the rebase worked - thanks! Will review as soon as possible.

@joewiz joewiz requested a review from a team August 8, 2019 16:45
@joewiz
Copy link
Member

joewiz commented Aug 28, 2019

@RemiKoutcherawy I can reproduce your first issue:

  • Upload A.xml to /db/apps
  • Select Done
  • Goto /db
  • Upload A.xml to /db
  • Click Done
  • Bug: A.xml is not in /db

However, I'm not following your second set of steps:

  • Select A.xml in /db/apps
  • Click Cut (Scissors)
  • Click Copy (Left of scissors)

I'm following you up to this point, but the next step doesn't make sense to me:

  • Goto /db/apps

I'm already in /db/apps from the first bullet point. Did you mean "Goto /db"? Could you help me understand please?

@RemiKoutcherawy
Copy link
Contributor Author

Sorry, correct sequence is

  • Select A.xml in /db/apps
  • Click Cut (Scissors)
  • Click Copy (Left of scissors)
  • Goto /db
  • Click Paste
  • Goto /db/apps
    --> Bug: A.xml is not in /db/apps
    Simply said, after clicking cut, you can no longer copy / paste.
    Rémi

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing this PR, the tests of eXide's File > Manage pane described in the report above proceed as follows:

Test 1

  • Select the Upload button
  • Upload a test document, e.g., A.xml, to /db/apps
  • Click Done
  • Goto /db
  • Upload A.xml to /db
  • Click Done

--> Result: A.xml appears in /db as expected - BUG RESOLVED!

Test 2

  • Select A.xml in /db/apps
  • Click Cut (Scissors)
  • Click Copy (Left of scissors)
  • Goto /db/apps
  • Click Paste
  • Goto /db

--> Result: A.xml remains in /db as expected - BUG RESOLVED!

@joewiz
Copy link
Member

joewiz commented Aug 30, 2019

Restarting CI in the hopes that the 2 failed checks (oraclejdk 8 & 11 on existdb:latest) now work?

@joewiz
Copy link
Member

joewiz commented Aug 30, 2019

CI tests are passing for existdb:release, and the failing tests are not the fault of this PR (noted in #228), so I'll merge this in preparation for the next release.

@joewiz joewiz merged commit de5dedf into eXist-db:develop Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants