New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix File/Manage/Upload and Cut/Copy/Paste #225
Conversation
Could you please rebase? |
There is only one file modified:
to squash commits. |
Ok, the rebase worked - thanks! Will review as soon as possible. |
@RemiKoutcherawy I can reproduce your first issue:
However, I'm not following your second set of steps:
I'm following you up to this point, but the next step doesn't make sense to me:
I'm already in /db/apps from the first bullet point. Did you mean "Goto /db"? Could you help me understand please? |
Sorry, correct sequence is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing this PR, the tests of eXide's File > Manage pane described in the report above proceed as follows:
Test 1
- Select the Upload button
- Upload a test document, e.g., A.xml, to /db/apps
- Click Done
- Goto /db
- Upload A.xml to /db
- Click Done
--> Result: A.xml appears in /db as expected - BUG RESOLVED!
Test 2
- Select A.xml in /db/apps
- Click Cut (Scissors)
- Click Copy (Left of scissors)
- Goto /db/apps
- Click Paste
- Goto /db
--> Result: A.xml remains in /db as expected - BUG RESOLVED!
Restarting CI in the hopes that the 2 failed checks (oraclejdk 8 & 11 on existdb:latest) now work? |
CI tests are passing for existdb:release, and the failing tests are not the fault of this PR (noted in #228), so I'll merge this in preparation for the next release. |
With eXide, select File > Manage, then:
--> Bug: A.xml is not in /db
--> Bug: A.xml is not in /db
I hope this will be merged in next release.