Switch login from GET to POST #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncdrum
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
LGTM
This would be a good opportunity to add login to the integration tests for eXide.
https://github.com/eXist-db/e2e-core/blob/master/cypress/integration/5.x.x/exide_spec.js
joewiz
force-pushed
the
fix/login-via-post
branch
from
592c0a0
to
b1b519f
Compare
|
CI tests are passing for existdb:release, and the failing tests are not the fault of this PR (noted in #228), so I'll merge this in preparation for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226.