Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead code in ConfigurationDocumentTrigger #3070

Open
adamretter opened this issue Oct 25, 2019 · 2 comments
Open

Dead code in ConfigurationDocumentTrigger #3070

adamretter opened this issue Oct 25, 2019 · 2 comments
Labels
investigate issues being looked at
Milestone
eXist-7.0.1

Comments

@adamretter
Copy link
Member

See - https://github.com/eXist-db/exist/blob/develop/exist-core/src/main/java/org/exist/config/ConfigurationDocumentTrigger.java#L93

The method finish in ConfigurationDocumentTrigger is no longer called. Should it be deleted?

It looks like the code in that method should go into afterDeleteDocument but it is already present in beforeDeleteDocument!

@shabanovd Any thoughts on this please?
@triage-new-issues triage-new-issues bot added the triage issue needs to be investigated label Oct 25, 2019
@adamretter adamretter added this to the eXist-5.0.1 milestone Oct 25, 2019
@shabanovd
Copy link
Member

@adamretter if 5.x was released then it should go to 6.x because it's api change, IMHO

@shabanovd
Copy link
Member

@adamretter on code itself, finish was here before triggers refactoring, so it can be safely deleted

@duncdrum duncdrum added the investigate issues being looked at label Oct 28, 2019
@triage-new-issues triage-new-issues bot removed the triage issue needs to be investigated label Oct 28, 2019
@adamretter adamretter modified the milestones: eXist-5.0.1, eXist-5.1.1 Nov 19, 2019
@adamretter adamretter modified the milestones: eXist-5.1.1, eXist-5.1.2 Dec 6, 2019
@adamretter adamretter modified the milestones: eXist-5.1.2, eXist-5.2.1 Jan 23, 2020
@adamretter adamretter modified the milestones: eXist-5.2.1, eXist-6.0.0 Mar 9, 2020
@line-o line-o modified the milestones: eXist-6.0.0, eXist-5.3.1 Jul 1, 2021
@adamretter adamretter modified the milestones: eXist-5.3.1, eXist-5.3.2 Dec 16, 2021
@adamretter adamretter modified the milestones: eXist-5.3.2, eXist-6.0.2 Feb 14, 2022
@adamretter adamretter modified the milestones: eXist-6.0.2, eXist-6.1.1 Jan 15, 2023
@adamretter adamretter modified the milestones: eXist-6.1.1, eXist-7.0.1 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate issues being looked at
Projects
None yet
Milestone
eXist-7.0.1
Development

No branches or pull requests
4 participants
@shabanovd @line-o @adamretter @duncdrum