Make Assertion Consumer Service configurable #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakl
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
@adamretter nice!
[please give me a moment to catch up on all the other PRs]
dizzzz
approved these changes
Oct 2, 2023
…ibute in the 'samlp:AuthnRequest' element to be configured
…on the 'samlp:AuthnRequest' instead of an 'AssertionConsumerServiceIndex'. This is needed for various IDP, including BoxyHQ
adamretter
force-pushed
the
feature/assertion-consumer-service
branch
from
3cf5a66
to
33ddf35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertionConsumerServiceIndexwas hard-coded to0, and is dependent on your IDP setup. It is now configurable from theconfig-exsaml.xmlfile (where it still defaults to0).AssertionConsumerServiceURLinstead of anAssertionConsumerServiceIndex. Which is permitted by the SAML Core spec. This adds that feature.