Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SAML response should be a well-formed XML document #26

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

adamretter
Copy link
Member

The SAML response should be a well-formed XML document and not a fragment, so we should not try and parse it as a fragment.

Additionally there is a current bug in eXist-db whereby if the SAML response includes an XML Declaration then fn:parse-xml-fragment#1 will throw an incorrect error, for example the following valid XQuery raises an error in eXist-db:

fn:parse-xml-fragment('<?xml version="1.0" encoding="UTF-8" ?>
<hello>world</hello>')

@adamretter adamretter added the bug Something isn't working label Aug 31, 2023
@adamretter adamretter requested a review from chakl August 31, 2023 16:35
@adamretter adamretter requested a review from dizzzz August 31, 2023 16:35
Copy link

@marmoure marmoure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ot a fragment. Additionally there is a current bug in eXist-db whereby if the SAML response includes an XML Declaration then fn:parse-xml-fragment#1 will throw an incorrect error.
@dizzzz dizzzz merged commit abf1425 into eXist-db:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants