Fix to correctly extract the SAML Response #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizzzz
approved these changes
Oct 2, 2023
…cument-node(element(samlp:Response)) and not an element(samlp:response), the code was previously look for an element and not a document-node. This fix now extracts the SAML Response element from the XML Document correctly
…SIS SAML v2.0 Core specification, see: http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf
adamretter
force-pushed
the
hotfix/saml-core-response-elements
branch
from
ad16dc6
to
99dd993
Compare
adamretter
added a commit
to evolvedbinary/existdb-saml
that referenced
this pull request
Jul 15, 2024
adamretter
added a commit
to evolvedbinary/existdb-saml
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML response is extracted from the HTTP Request Body via
fn:parse-xml-fragment#1. The existing XQuery code was expectingfn:parse-xml-fragment($resp)to return a value of typeelement(samlp:Response), however that is incorrect in theory, and also does not work in practice (tested on eXist-db 6.x.x and 7.x.x). The W3 spec for the XQuery functionfn:parse-xml-fragment#1specifies that a value of typedocument-node(element(samlp:Response))will be returned. This PR fixes that bug.