Reinstate support for eXist-db 4.x.x #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
added a commit
to evolvedbinary/exist
that referenced
this pull request
Jun 30, 2022
invalid rather than continuing silently. See eXist-db/public-repo#78
dizzzz
approved these changes
Jul 1, 2022
joewiz
reviewed
Jul 5, 2022
joewiz
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Tested on an eXist 6.1.0 system and confirmed that the request to http://localhost:8080/exist/apps/public-repo/find?abbrev=dashboard&processor=6.0.1-SNAPSHOT&zip=yes causes dashboard-2.0.6.xar.zip to be downloaded, and the zip file itself contains dashboard-2.0.6.xar. From my understanding of the issue, this is the behavior that eXist 4.x's build process relies on to download packages intended for the autodeploy facility.
|
Thanks so much @joewiz :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eXist-db 4.x.x build process requires the public-repo to deliver a Zip file containing the Xar file. This was working in the past. However, it now looks like support for eXist-db 4.x.x was accidentally removed through two refactorings:
This PR reinstates support for eXist-db 4.x.x.