Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat issue view #23

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

skalimer0
Copy link
Contributor

Manage risks in issue's view :

  • Relate existing risk on issue (with autocomplete input (like related issues)
  • Create new risk (on issue's project) and auto relate it on the issue
  • Delete risk_issue relation

@xel1045
Copy link
Member

xel1045 commented Apr 25, 2023

Sorry for the delay, I'm migrating to a new laptop and I just reconfigured my Ruby setup.

You seem to have more than one change in the PR.

You're also adding risk grouping support, but the feature doesn't look finished. When I group risks by probability or impact, the key is displayed instead of the label. Can you move this feature to another PR to facilitate the review?

For the main functionality (i.e., the issue view), you've also changed the risk form, but select are now truncated. Would it be possible to avoid touching this form? Also, to facilitate future maintenance of the functionality, I think it would have been easier to avoid using a popup and simply redirect the user to the risk creation form with a query parameter ?link_to_issue=XYZ

Thanks!

@skalimer0
Copy link
Contributor Author

Sorry for the risk_query.rb, i've forgotten it (i have some features on this plugin).

To use this form in a "Add Risk" popup on Issue form i need to change like that... and other functions use popup on issue form (like create new version). I'll check tomorrow "select are now truncated."

To speak other feat., i make patch to redmine project to use diff Journal (who's actually in error on risk's description for example).

@skalimer0
Copy link
Contributor Author

Hello I can't reproduce the bug on risk form. No truncated element. Can you explain or show on a picture ?

@xel1045
Copy link
Member

xel1045 commented Apr 28, 2023

Sure, here's how it looks in your branch:

Screenshot 2023-04-28 at 13 35 19

And before, it was like this:

Screenshot 2023-04-28 at 13 36 00

As you can see, the dropdowns are all shrunk and we cannot see the selected value properly.

@skalimer0
Copy link
Contributor Author

OK, i see.... I'm using PurpleMine theme and i don't have this problem...
I'll check that

@skalimer0
Copy link
Contributor Author

skalimer0 commented May 24, 2024

Hello,
Do you have other problems with this PR ?

We are migrating our REDMINE to version 5 and I would like to move forward on our various developments on the plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants