Rewrite wrapper types to use downcasting approach and cleanup duplica… #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper code has become muddle with multiple inline transformations with inconsistent behavior. This change throws it all away and replaces it with a consistent approach whereby there are
All matchers apply a "down-casting" approach whereby the actual type is cast to the expected type before comparing. Invalid down-casts i.e. up-casts of say LocalDate to LocalDateTime are not supported because it leads to dubious tests whereby missing information such as time needs to be made up