Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite wrapper types to use downcasting approach and cleanup duplica… #29

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

stewbis
Copy link
Member

@stewbis stewbis commented Sep 19, 2019

Wrapper code has become muddle with multiple inline transformations with inconsistent behavior. This change throws it all away and replaces it with a consistent approach whereby there are

  • Converters, which convert from temporal type A -> B
  • Providers, which provide a temporal type B
  • Functions, which perform date functions on type B

All matchers apply a "down-casting" approach whereby the actual type is cast to the expected type before comparing. Invalid down-casts i.e. up-casts of say LocalDate to LocalDateTime are not supported because it leads to dubious tests whereby missing information such as time needs to be made up

@stewbis stewbis force-pushed the rewrite_wrappers branch 2 times, most recently from 117c0e9 to 60bf5db Compare September 20, 2019 05:15
@coveralls
Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage increased (+0.6%) to 88.262% when pulling 8d83580 on rewrite_wrappers into 703234d on master.

@stewbis stewbis merged commit be960db into master Sep 20, 2019
@stewbis stewbis deleted the rewrite_wrappers branch September 20, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants