ANAME loops #70
Merged
ANAME loops #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matje
reviewed
Jul 2, 2019
| resolve the ANAME target independently. There is no longer a single component | ||
| keeping the complete processing state and as a result the loop cannot be | ||
| detected and broken explicitly. Instead, the servers need to rely on secondary | ||
| symptoms indicating presence of the loop such as resolution timeouts. |
There was a problem hiding this comment.
Suggested change
| symptoms indicating presence of the loop such as resolution timeouts. | |
| symptoms indicating presence of the loop such as resolution timeouts, | |
| or tracking the ANAME resolution depth. |
There was a problem hiding this comment.
Matthijs, I think there is no way to track ANAME resolution path. How would that work?
There was a problem hiding this comment.
Depth, not path. Everytime you encounter a new ANAME or CNAME you increment the depth. If that reaches a certain threshold the lookup is considered to be failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appendix with ANAME loops detection discussion to address #45.
I think the ANAME address record substitution will be the most complex part to implement from the whole draft. The loops are tricky and I find it particularly difficult to describe due to many edge cases and various options. Feel free to suggest edits.
cc @matje