Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prefix matches for meanings? #30

Closed
eagleflo opened this issue Sep 8, 2023 · 1 comment
Closed

Allow prefix matches for meanings? #30

eagleflo opened this issue Sep 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@eagleflo
Copy link
Owner

eagleflo commented Sep 8, 2023

~ % jisho prime minister
首相【しゅしょう】- prime minister, chancellor (Germany, Austria, etc.), premier
宰相【さいしょう】- prime minister, premier, chancellor
首班【しゅはん】- head, leader, prime minister
PM【ピー・エム】- private message, PM, post-meridiem, afternoon, project manager, product manager, particulate matter, prime minister
プライムミニスター - prime minister
~ % jisho 総理大臣
総理大臣【そうりだいじん】- prime minister (as the head of a cabinet government), premier

Well, that's not optimal. It looks like we currently only collect exact matches with an English search term.

I'm wondering what kind of hassle would it be to allow prefix matches for meanings -- would that lead to a flood of irrelevant results for shorter search terms? This is a case where I definitely think the additional clarification should not block inclusion.

If this pattern of "right answer (additional note)" is common enough, maybe it ought to be handled separately.

@eagleflo eagleflo added the bug Something isn't working label Sep 8, 2023
@eagleflo
Copy link
Owner Author

eagleflo commented Dec 4, 2023

I'm starting to think that this should most definitely go in, but only for English search terms at first, and with a possibility to look look for exact matches only.

@eagleflo eagleflo self-assigned this Dec 4, 2023
eagleflo added a commit that referenced this issue Apr 14, 2024
This cuts down on superfluous results with shorter words.

The right fix for issues like #30 is to omit parenthetical explanations
from our lookup dictionaries.
eagleflo added a commit that referenced this issue Apr 14, 2024
This is a better fix for the original problem in #30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant