Adding automated tests. #30

jeff-cohere · 2022-10-06T18:47:11Z

This adds some automated tests for MAM4xx.

jeff-cohere · 2022-10-06T19:11:38Z

Okay, this exhibits all of the usual irritations with submodules, SSH keys and all that, so it's not the quick victory I was hoping for.

This adds some automated tests for MAM4xx. NOTE: we need to open up the HAERO repo before this branch graduates to a PR.

jeff-cohere · 2022-10-10T17:12:40Z

Finally, we're getting somewhere.

@pbosler , this workflow is doing what it needs to do. In particular, one of the single-precision builds is failing on a static assertion in kohler.hpp, line 125. Because this file is included by the only source file in the mam4xx_tests library, we need to find a single-precision solution for this issue before this PR is merged. Because you devised this testing scenario and likely have the most well-formed opinions about single- and double-precision in this context, I'm delegating this to you. I'll write up an issue. You can fix in this branch directly or merge your own PR after which this one can go in.

@cameronrutherford , when we merge this PR, we'll have basic GitHub Actions CI for CPU testing.

…Kohler polynomial requires double precision due to numerical ill-conditioning)

pbosler · 2022-10-10T22:20:00Z

Commit 7b41699 failed the build stage with an ekat pack macro expansion error with single precision, pack size 4. That configuration builds and tests pass on my linux box, so I can't reproduce it yet.

Commit 58d6a35 fails at the install stage, which I don't test.

jeff-cohere · 2022-10-10T22:35:25Z

The install failure was my fault--we don't actually build anything that can be installed just yet! Though that will change in the near future, when we install headers for EAMxx.

pbosler

That array bounds

cameronrutherford

This has already been merged, but I was out of the office and was going through emails. I think I should create issues for these and we can address them in the future, but I wanted to also open threads for discussion before doing so.

cameronrutherford · 2022-10-12T22:12:07Z

.github/workflows/auto_test.yml

+          -DMAM4XX_HAERO_DIR=`pwd`/haero_install \
+          -G "Unix Makefiles"
+
+# TODO: clang-format seems unstable under different versions. Not helpful!


Yes, I ran into this for ExaGO recently - we ended up requiring a specific version of clang-format for all developers.

This is quite annoying, but if you pin a version, apply a single formatting commit, and enforce it moving forward, you shouldn't run into it again...

For some reason I was also finding that clang-format would be reluctant to pick up the provided .clang-format without forcing it to dump it's used configuration before running formatting checks. It seemed like a bug that I was running into with clang-format version 10.

cameronrutherford · 2022-10-12T22:13:15Z

src/tests/kohler_verification.cpp

@@ -1,8 +1,9 @@
 #include "kohler_verification.hpp"
-#include "mam4_test_config.hpp"
+#ifdef HAERO_DOUBLE_PRECISION


Is this an #ifdef for the whole file? Would it be better to configure usage of this file at the CMake level instead?

cameronrutherford · 2022-10-12T22:14:25Z

src/tests/kohler_verification.hpp

@@ -1,6 +1,8 @@
 #ifndef MAM4XX_KOHLER_VERIFICATION_HPP
 #define MAM4XX_KOHLER_VERIFICATION_HPP

+#include <haero/haero.hpp>
+#ifdef HAERO_DOUBLE_PRECISION


Similar thought here - I think we should be able to handle this at the CMake level, not in the header file.

We should perhaps include this header conditionally in other files as well based on whether we build with double or single precision.

I'm ok with changing it to a CMake-handled inclusion. I wanted CI to get going quickly, and this was my first fast idea that worked.

cameronrutherford · 2022-10-12T22:15:19Z

.github/workflows/auto_test.yml

+        cd build
+        ctest -V
+
+# No install target (yet?)


I wrote all of ExaGO and HiOp's CMake install configurations, and would be happy to take a stab at helping here.

I have spent quite some time in the weeds of CMake, and it should make this relatively painless to configure.

cameronrutherford · 2022-10-12T22:17:43Z

src/tests/CMakeLists.txt

 EkatCreateUnitTest(mam4_kohler_unit_tests mam4_kohler_unit_tests.cpp
  LIBS mam4xx_tests ${HAERO_LIBRARIES})
-


This should disable building and include of related tests into CMake - https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/tree/master/buildsystem/cmake. We have developed some really helpful CMake macros that could be useful to enable this out of the box.

jeff-cohere added the testing label Oct 6, 2022

jeff-cohere force-pushed the jeff-cohere/ci-auto-test branch from 476e9fa to 09ebfe9 Compare October 6, 2022 19:07

jeff-cohere mentioned this pull request Oct 7, 2022

CI Testing #29

Closed

jeff-cohere force-pushed the jeff-cohere/ci-auto-test branch from b909f97 to 72c453d Compare October 10, 2022 16:17

jeff-cohere added 5 commits October 10, 2022 09:41

Adding automated tests.

16e6c11

This adds some automated tests for MAM4xx. NOTE: we need to open up the HAERO repo before this branch graduates to a PR.

Another stab at building Haero.

478003b

Made Haero paths relative.

61d18fb

Fixed a typo.

1d9769b

Fixing haero_install path.

2553717

jeff-cohere force-pushed the jeff-cohere/ci-auto-test branch from 1a283e1 to 2553717 Compare October 10, 2022 16:41

Trying again.

6f15c0b

jeff-cohere mentioned this pull request Oct 10, 2022

Single precision build fails in Kohler verification test. #31

Closed

pbosler added 2 commits October 10, 2022 16:03

disabling Kohler verification tests for single-precision builds (the …

7b41699

…Kohler polynomial requires double precision due to numerical ill-conditioning)

clang-format. closes #31

58d6a35

Removed unnecessary install stage from CI workflow.

a064c02

jeff-cohere added 2 commits October 10, 2022 15:49

A fix for uninitialized Packs.

4b74907

Another attempt.

5f9fc4b

jeff-cohere requested review from pbosler and cameronrutherford October 10, 2022 23:08

pbosler approved these changes Oct 10, 2022

View reviewed changes

jeff-cohere merged commit 3af5369 into main Oct 10, 2022

jeff-cohere deleted the jeff-cohere/ci-auto-test branch October 10, 2022 23:20

cameronrutherford reviewed Oct 12, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding automated tests. #30

Adding automated tests. #30

jeff-cohere commented Oct 6, 2022

jeff-cohere commented Oct 6, 2022

jeff-cohere commented Oct 10, 2022

pbosler commented Oct 10, 2022

jeff-cohere commented Oct 10, 2022

pbosler left a comment

cameronrutherford left a comment

cameronrutherford Oct 12, 2022

cameronrutherford Oct 12, 2022

cameronrutherford Oct 12, 2022

pbosler Oct 12, 2022

cameronrutherford Oct 12, 2022

cameronrutherford Oct 12, 2022

		EkatCreateUnitTest(mam4_kohler_unit_tests mam4_kohler_unit_tests.cpp
		LIBS mam4xx_tests ${HAERO_LIBRARIES})

Adding automated tests. #30

Adding automated tests. #30

Conversation

jeff-cohere commented Oct 6, 2022

jeff-cohere commented Oct 6, 2022

jeff-cohere commented Oct 10, 2022

pbosler commented Oct 10, 2022

jeff-cohere commented Oct 10, 2022

pbosler left a comment

Choose a reason for hiding this comment

cameronrutherford left a comment

Choose a reason for hiding this comment

cameronrutherford Oct 12, 2022

Choose a reason for hiding this comment

cameronrutherford Oct 12, 2022

Choose a reason for hiding this comment

cameronrutherford Oct 12, 2022

Choose a reason for hiding this comment

pbosler Oct 12, 2022

Choose a reason for hiding this comment

cameronrutherford Oct 12, 2022

Choose a reason for hiding this comment

cameronrutherford Oct 12, 2022

Choose a reason for hiding this comment