Remove a:module arguments [fix for 5.5] #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw what are your thoughts on changing the arguments to |
andy-morris
changed the title
andy-morris
changed the title
Remove the 'a:module' arguments from the calls to `ghcmod#build_command` in the sig, split, info, and type functions. No version check because they've actually been optional since v5.0, but now they have been removed completely. Also replace them with `...` in the function's argument list, so that calls with or without them are accepted, In case there are any other plugins based on ghcmod-vim. For the same reason, `ghcmod#detect_module` is still there.
andy-morris
force-pushed
the
module-args
branch
from
60ddf70
to
4aab6e1
Compare
|
[rebased for current HEAD.] |
eagletmt
added a commit
that referenced
this pull request
Jan 25, 2016
Remove a:module arguments [fix for 5.5]
|
🆒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the 'a:module' arguments from the calls to
ghcmod#build_commandinthe sig, split, info, and type functions. No version check because they've
actually been optional since v5.0, but now they have been removed completely.
Also replace them with
...in the function's argument list, so that callswith or without them are accepted, In case there are any other plugins based
on ghcmod-vim. For the same reason,
ghcmod#detect_moduleis still there.