Support tags for task definition and propagate them to ECS tasks #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cost allocation tags feature of AWS is useful to understand cost condition. In general, also tags are useful for metadata of AWS resources.
ECS supports tagging for task definitions, tasks and services. Tags attached to task definition and service can be propagated to its related running tasks. cf. https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-using-tags.html
This patch adds a support tagging for task definitions and propagate these tags to tasks generated from that definition.
What not to do
This change doesn't support tagging for services and propagate tags only from task definitions (it means no service propagate tags).
This is for simplicity of implementation and specification of Hako. When we use Hako, 1 hako app has 1 service and 1 task definition basically. So it's enough define tags to a task definition and propagate them to running tasks generated from the definition. I think this is natural and it can cover general use-cases.
Hako config
@eagletmt Please review 馃檹