Merge 0fe0c10 into f9f928a

README.md

@@ -89,6 +89,15 @@ end
 
 Note that Article and Category shares their connections.
 
+### Switching connections in relation
+
+```ruby
+Article.using_readonly.first # Read from db-blog-slave
+Article.where(id: 1).using_writable.update_all(title: 'new title') # Write to db-blog-master
+```
+
+Note that `AR::Relation` extension is only supported in Rails 4.0 or higher.
+
 ### Query cache
 `Model.cache` and `Model.uncached` enables/disables query cache for both
 readonly connection and writable connection.

lib/switch_point.rb

@@ -65,9 +65,12 @@ def with_mode(mode, *names, &block)
   require 'switch_point/connection'
   require 'switch_point/model'
   require 'switch_point/query_cache'
+  require 'switch_point/relation'
 
   ActiveRecord::Base.send(:include, SwitchPoint::Model)
   ActiveRecord::ConnectionAdapters::AbstractAdapter.class_eval do
     prepend SwitchPoint::Connection
   end
+  ActiveRecord::Relation.send(:prepend, SwitchPoint::Relation)
+  ActiveRecord::Querying.delegate(:using_readonly, :using_writable, to: :all)
 end

lib/switch_point/relation.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+module SwitchPoint
+  module Relation
+    attr_writer :proc_to_give_switch_point_mode
+
+    def exec_queries(*)
+      with_switch_point_mode { super }
+    end
+
+    def calculate(*)
+      with_switch_point_mode { super }
+    end
+
+    def delete_all(*)
+      with_switch_point_mode { super }
+    end
+
+    def destroy(*)
+      with_switch_point_mode { super }
+    end
+
+    def destroy_all(*)
+      with_switch_point_mode { super }
+    end
+
+    def update(*)
+      with_switch_point_mode { super }
+    end
+
+    def update_all(*)
+      with_switch_point_mode { super }
+    end
+
+    def with_switch_point_mode
+      if @proc_to_give_switch_point_mode
+        @proc_to_give_switch_point_mode.call { yield }
+      else
+        yield
+      end
+    end
+    private :with_switch_point_mode
+
+    def using_readonly
+      if klass.switch_point_proxy
+        all.tap do |rel|
+          rel.proc_to_give_switch_point_mode = klass.method(:with_readonly)
+        end
+      else
+        raise UnconfiguredError.new("#{name} isn't configured to use switch_point")
+      end
+    end
+
+    def using_writable
+      if klass.switch_point_proxy
+        all.tap do |rel|
+          rel.proc_to_give_switch_point_mode = klass.method(:with_writable)
+        end
+      else
+        raise UnconfiguredError.new("#{name} isn't configured to use switch_point")
+      end
+    end
+  end
+end

spec/switch_point/relation_spec.rb

@@ -0,0 +1,226 @@
+# frozen_string_literal: true
+
+RSpec.describe SwitchPoint::Relation do
+  before do
+    skip 'AR::Relation extension is only supported in Rails 4.0 or higher.' if ActiveRecord::VERSION::MAJOR < 4
+
+    Book.with_writable do
+      Book.create!(id: 1)
+    end
+
+    Book.with_readonly do
+      Book.connection.execute('INSERT INTO books (id) VALUES (99)')
+    end
+  end
+
+  describe '#using_readonly' do
+    context 'using take' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect(Book.where(id: 1).using_readonly.count).to be_zero
+        end
+      end
+    end
+
+    context 'using count' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect(Book.where(id: 1).using_readonly.count).to be_zero
+        end
+      end
+    end
+
+    context 'using update' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.update(99, id: 0) }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using update_all' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.update_all(id: 99) }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using delete' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.delete(99) }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using delete_all' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.delete_all }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using destroy' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.destroy(99) }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using destroy_all' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect { Book.all.using_readonly.destroy_all }.to raise_error(SwitchPoint::ReadonlyError)
+        end
+      end
+    end
+
+    context 'using delegation' do
+      it 'connect to readonly db' do
+        Book.with_writable do
+          expect(Book.using_readonly.where(id: 99).count).to eq 1
+        end
+      end
+    end
+  end
+
+  describe '#using_writable' do
+    context 'using take' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.where(id: 1).using_writable.take).to be_a Book
+        end
+      end
+    end
+
+    context 'using count' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.where(id: 1).using_writable.count).to eq 1
+        end
+      end
+    end
+
+    context 'using update' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.all.using_writable.update(1, id: 0)).to be_a Book
+        end
+      end
+    end
+
+    context 'using update_all' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.where(id: 1).using_writable.update_all(id: 0)).to eq 1
+        end
+      end
+    end
+
+    context 'using delete' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.all.using_writable.delete(1)).to eq 1
+        end
+      end
+    end
+
+    context 'using delete_all' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.where(id: 1).using_writable.delete_all).to eq 1
+        end
+      end
+    end
+
+    context 'using destroy' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expect(Book.all.using_writable.destroy(1)).to be_a Book
+        end
+      end
+    end
+
+    context 'using destroy_all' do
+      it 'connect to writable db' do
+        Book.with_readonly do
+          expected = [Book.where(id: 1).using_writable.take]
+          expect(Book.where(id: 1).using_writable.destroy_all).to eq expected
+        end
+      end
+    end
+
+    context 'using delegation' do
+      it 'connect to writable db' do
+        Book.with_writable do
+          expect(Book.using_writable.where(id: 1).count).to eq 1
+        end
+      end
+    end
+  end
+
+  context 'without use_switch_point' do
+    describe '#using_readonly' do
+      it 'raises error' do
+        expect { Note.all.using_readonly }.to raise_error(SwitchPoint::UnconfiguredError)
+      end
+    end
+
+    describe '#using_writable' do
+      it 'raises error' do
+        expect { Note.all.using_writable }.to raise_error(SwitchPoint::UnconfiguredError)
+      end
+    end
+  end
+
+  context 'when reuse relation' do
+    describe '#using_readonly' do
+      it 'does not make destructive changes' do
+        rel = Book.where(id: 1)
+
+        Book.with_writable do
+          expect(rel.using_readonly.take).to be_nil
+          expect(rel.take).to be_a Book
+        end
+      end
+
+      it 'reset the result' do
+        rel = Book.using_readonly
+
+        Book.with_writable do
+          expect(rel.map(&:id)).to eq [99]
+        end
+
+        Book.with_readonly do
+          expect(rel.using_writable.map(&:id)).to eq [1]
+        end
+      end
+    end
+
+    describe '#using_writable' do
+      it 'does not make destructive changes' do
+        rel = Book.where(id: 1)
+
+        Book.with_readonly do
+          expect(rel.using_writable.take).to be_a Book
+          expect(rel.take).to be_nil
+        end
+      end
+
+      it 'reset the result' do
+        rel = Book.using_writable
+
+        Book.with_readonly do
+          expect(rel.map(&:id)).to eq [1]
+        end
+
+        Book.with_writable do
+          expect(rel.using_readonly.map(&:id)).to eq [99]
+        end
+      end
+    end
+  end
+end