New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-71804 Missing dependencies #1314
Conversation
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
@JorgeFerrer @ealonso This is the solution for https://issues.liferay.com/browse/LPS-67886 (LPS-71804 is a technical task). I tried to make some optimisations for a better performance, but anyway, it is impossible to avoid an additional service call(and DB call) which is needed to get Group's friendly URL (or alternative URL if needed), so technically there is no way to keep the same performance since this part(Groups friendly URL resolution) affects directly or indirectly almost every test we have. Thanks. |
ab5f96a
to
3e6644e
Compare
Just started reviewing :) |
Pull request submitted to jkappler#86. |
No description provided.