Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-71804 Missing dependencies #1314

Closed
wants to merge 16 commits into from

Conversation

pavel-savinov
Copy link

@pavel-savinov pavel-savinov commented Dec 22, 2017

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@pavel-savinov
Copy link
Author

@JorgeFerrer @ealonso This is the solution for https://issues.liferay.com/browse/LPS-67886 (LPS-71804 is a technical task). I tried to make some optimisations for a better performance, but anyway, it is impossible to avoid an additional service call(and DB call) which is needed to get Group's friendly URL (or alternative URL if needed), so technically there is no way to keep the same performance since this part(Groups friendly URL resolution) affects directly or indirectly almost every test we have.
Maybe it makes sense to run performance tests, contrast them with the feature importance and then decide if we really want to keep investigating it or discard this feature for now.

Thanks.

@ealonso
Copy link
Owner

ealonso commented Jan 11, 2018

Just started reviewing :)

:octocat: Sent from GH.

@ealonso
Copy link
Owner

ealonso commented Jan 11, 2018

Pull request submitted to jkappler#86.

:octocat: Sent from GH.

@ealonso ealonso closed this Jan 11, 2018
@pavel-savinov pavel-savinov deleted the LPS-71804 branch August 20, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants