Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-83312 Check group admin permission #1872

Closed
wants to merge 997 commits into from
Closed

LPS-83312 Check group admin permission #1872

wants to merge 997 commits into from

Conversation

stsquared99
Copy link

No description provided.

stian-sigvartsen and others added 30 commits August 16, 2018 09:32
@stian-sigvartsen @brianchandotcom
LPS-84379 Auto SF (fix indentation)
c04036c
@stian-sigvartsen @brianchandotcom
LPS-82716 innerHTML is not a function (regression in 983123c)
27b2463
@stian-sigvartsen @brianchandotcom
LPS-82716 comment-taglib's page.jsp explicitly targets /login/login f…
0498f54 
…or FAST_LOGIN portlet but the render command doesn't support this portlet
@brianchandotcom
LPS-73530 Use info for PortalException
1624a4b
@jkappler @brianchandotcom
LPS-73530 Avoid including error.jsp if there aren't any exceptions
6ca7ba7
@robertoDiaz @brianchandotcom
LPS-84223 Modify the logic to validate the DL files when they should …
b4a3c7f 
…be validated.
@jkappler @brianchandotcom
LPS-84223 Avoid setting the protocol
37ac39c
@jkappler @brianchandotcom
LPS-84223 SF
f37c854
@jkappler @brianchandotcom
LPS-84223 Rename var
dbb679e
@yichenroy @brianchandotcom
LRQA-42701 Add a modules unit batch for project templates
ec5aa13
@yichenroy @brianchandotcom
LRQA-42701 Update test properties for modules unit and modules unit p…
11a3270 
…roject templates batch
@yichenroy @brianchandotcom
LRQA-42701 Update available test suite names in ci.properties
75986cb
@yichenroy @brianchandotcom
LRQA-42701 Add modules unit project templates batch to relevant
ad09b61
@yichenroy @brianchandotcom
LRQA-42701 Add system property for Project Templates to build.properties
d16e920
@brianchandotcom @liferay-continuous-integration
APIO-162 Add @review please
72e24aa
@brianchandotcom @liferay-continuous-integration
APIO-162 Better performance
fe47234
@brianchandotcom @liferay-continuous-integration
APIO-162 SF
ca053ec
@brianchandotcom @liferay-continuous-integration
APIO-162 Wordsmith
050801a
@ngaskill @liferay-continuous-integration
LRDOCS-5613 javadoc review
1340d29
@javiergamarra @liferay-continuous-integration
LRDOCS-5613 sf
31a37f1
@javiergamarra @liferay-continuous-integration
LRDOCS-5613 tests sf
da9b4f1
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/apio-architect/.gitrepo'.
0e27561
@vitoria-mendes @brianchandotcom
LPS-84270 fixed top and bottom margins
f0dc803
@4lejandrito @brianchandotcom
LPS-84270 Auto SF
916946d
@gregory-bretall @brianchandotcom
LPS-84148 Make z-index higher than that of the product menu only on s…
3a20f8e 
…mall screen sizes
@gregory-bretall @brianchandotcom
LPS-84148 Lower z-index of the AlloyEditor toolbar to be inline with …
8a3164e 
…the Product Menu z-index from LPS-78321
@pat270 @brianchandotcom
LPS-82855 Search Iterator Taglib should have option to change contain…
924d530 
…erCssClass
@brianchandotcom
LPS-82855 - Rename attribute to searchResultCssClass since it wraps o…
c11dea0 
…nly the search results and not the entire wrapping div
@brianchandotcom
LPS-82855 - Add searchResultCssClass attribute to default taglib code
29e5023
@brianchandotcom
LPS-82855 - Update SEMVER
c78f28f
shuyangzhou and others added 24 commits August 18, 2018 21:43
@shuyangzhou @brianchandotcom
LPS-80310 SF
af695ba
@shuyangzhou @brianchandotcom
LPS-80310 Optimize _addClosingTags
3a80eb4
@shuyangzhou @brianchandotcom
LPS-80310 Reuse SB
97b0a9b
@shuyangzhou @brianchandotcom
LPS-80310 Don't swallow error stack.
feb43a5
@ngriffin7a @brianchandotcom
LPS-80310 Change well-formed XML utility methods to static for easier…
293effb 
… testing
@ngriffin7a @brianchandotcom
LPS-80310 Tests for well-formed XML utility methods
df68df9
@shuyangzhou @brianchandotcom
LPS-80310 It is an unit test.
2dfdc5f
@shuyangzhou @brianchandotcom
LPS-80310 It is static method
810a68b
@shuyangzhou @brianchandotcom
LPS-80310 Use varargs
cbd8d7a
@shuyangzhou @brianchandotcom
LPS-80310 Don't run test logic in a loop. Invoke them one by one expl…
5ec4c62 
…icitly, this way if one fail, you can easily tell which one it was base on the line number from error stack.
@brianchandotcom
LPS-80310 Rename
ba0a915
@joshuacords @brianchandotcom
LPS-84283 Fix spelling
b7a7b34
@SamZiemer @brianchandotcom
LPS-84283 build lang
e91ad0b
@brianchandotcom
OAUTH2-218 Deduplicate scopes
f3bf233
@brianchandotcom
OAUTH2-218 Gogo command to list scopes
6448655
@topolik @brianchandotcom
OAUTH2-218 Rename to follow other OSGICommands
8f0b461
@topolik @brianchandotcom
OAUTH2-218 SF - unused
60e886f
@topolik @brianchandotcom
OAUTH2-218 SF - rename
aa173b5
@topolik @brianchandotcom
OAUTH2-218 Display bundle ID
f01d13a
@brianchandotcom
OAUTH2-218 Hugo SF, wrong class name
b37bc5c
@brianchandotcom
OAUTH2-218 SF
cd184cd
@izaera
LPS-82998 Fix JSP
fca0bc8
LPS-82998
5962d12
LPS-83312 Check group admin permission
89f529a
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@stsquared99
Copy link
Author

Hi Eudaldo, Sergio sent me your way.

https://issues.liferay.com/browse/LPS-83312
Basically in LayoutPermissionImpl we are currently not checking for the group admin permission. This seems like it might be the right place for it, but we were hoping someone more knowledgable would be able to take a look.

Thanks!

@pavel-savinov
Copy link

Just started reviewing :)

:octocat: Sent from GH.

@pavel-savinov
Copy link

Hi @stsquared99,
It makes sense. Sent to Brian: brianchandotcom#62415
Thanks.

@ealonso ealonso closed this Aug 27, 2018
@stsquared99 stsquared99 deleted the master-LPS-83312 branch August 27, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone