LPS-99882 Remove empty string from character blacklist, as every string contain the empty string, it would make creation of journal folder impossible #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content-page-editor-web
…ay.getURLCurrent(). getURLCurrent() only works when calling from the displayContext because the url is the correct one, calling it from the resourceCommand retrieve a invalid url
…ulate the url from the resourceCommand. Remove some query param that are not necessary and set the selectedPanel
Update dependencies to bring in: liferay/liferay-js-toolkit#380 This means that from now on, we will perform dead code elimination during bundling, which means that modules like frontend-js-react-web will now include only development code, or only production code, respecting the setting of nodejs.node.env in the build.properties. This will reduce bundle sizes, improve the debugging experience, and eliminate some ugly errors in the browser console. The eslint-config-liferay update activates one new rule, which required a lint fix in item-selector-taglib.
…n where the fragment is moved
… times in the html of a fragment
…ng contain the empty string, it would make creation of journal folder impossible
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Just started reviewing :) |
Sent from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.