Skip to content

Commit

Permalink
Remove href attribures (#73)
Browse files Browse the repository at this point in the history
* Remove href attribures as they are not need and cause problems with routing

* set cursor: pointer to get anchor tag behavior
  • Loading branch information
Tim Robertson authored and ealush committed Aug 23, 2018
1 parent 00d6f81 commit c8a4dc9
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .gitignore
@@ -1,4 +1,5 @@
node_modules/
*.log
.vscode
storybook-static
storybook-static
*.swp
2 changes: 1 addition & 1 deletion src/CategoriesNav/index.js
Expand Up @@ -9,7 +9,7 @@ function CategoriesNav({onClick}) {
return (
<nav>{
categories.map((category, index) => (
<a href="#!" className={category.name} key={index} onClick={(e) => onClick(e, index)}>
<a className={category.name} key={index} onClick={(e) => onClick(e, index)}>
<i/>
<span className="hidden">{category.name}</span>
</a>
Expand Down
3 changes: 1 addition & 2 deletions src/DiversityPicker/index.js
Expand Up @@ -30,8 +30,7 @@ function DiversityPicker({ index, assetPath, emojiResolution, onEmojiClick, clos
diversities && diversities.map((diversity) => {
const style = bgImage({ unified: diversity, assetPath, emojiResolution });
return (
<a href="#!"
key={diversity}
<a key={diversity}
style={style}
className="emoji"
onClick={((e) => onClick(diversity, e))}/>
Expand Down
3 changes: 1 addition & 2 deletions src/Emoji/index.js
Expand Up @@ -111,8 +111,7 @@ class Emoji extends Component {
style.order = emoji.order;

return (
<a href="#!"
className={className}
<a className={className}
onClick={this.onClick}
onMouseEnter={this.onMouseEnter}
onMouseLeave={this.onMouseLeave}
Expand Down
1 change: 1 addition & 0 deletions src/EmojiPicker/style.scss
Expand Up @@ -20,6 +20,7 @@

a {
outline: none;
cursor: pointer;
}

ul {
Expand Down
2 changes: 1 addition & 1 deletion src/SkinTones/index.js
Expand Up @@ -30,7 +30,7 @@ function SkinTones({onModifierClick, activeModifier, spread }) {

return (
<li className={modifierClass} style={style} key={modifier}>
<a href="#!" className="st" onClick={(e) => onModifierClick(e, modifier)}></a>
<a className="st" onClick={(e) => onModifierClick(e, modifier)}></a>
</li>
);
})}
Expand Down
2 changes: 1 addition & 1 deletion src/constants/index.js
@@ -1,6 +1,6 @@
import { keywords } from '../emoji-data';
import keywordsSingleChar from '../SearchBar/helpers/init_keywords_single';
import * as scss from '../base.scss';
import * as scss from '../base.scss'; // eslint-disable-line no-unused-vars

// view
export const MIN_SCROLLBAR_HEIGHT_PADDED = 15;
Expand Down

0 comments on commit c8a4dc9

Please sign in to comment.