-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property to add loading inside of picker. #148
Comments
hey @matheus-garcia Because definitely we don't want to be waiting for all 1500+ emojis to be rendered. Would the initial group suffice in your opinion? |
Yes, any group loaded would remove the loading screen. |
So this requires some work, and in some ways is related to the lagging search issue #133 . Since I batch-render everything at once I don't really have an easy to set and stop the loader. I'll have to make some changes to introduce that. In the meantime I'll add some other small perf wins to at least make it feel a little better. |
@matheus-garcia I just released version 3.2 which slightly improved the perceived performance of the initial load. It is not a game changer, it just attempts to load the first category before rendering all the rest. It might help until I actually implement something more sophisticated. |
Thanks, I'll check it out :) |
I'd like to vote for this feature as well |
Let's add this for a new version tracking. Not sure how an API would look like, probably give you the ability to provide a custom spinner. |
A skeleton loader would probably look best. Please implement this feature soon, as the user will think nothing is happening after they click to open this emoji picker and there is no visual indication that something is happening. it takes 2 seconds for me between clicking and something showing up on the screen. |
The component itself is really good, but since there are many stickers to load, it takes a time to load the component, it would be awesome to have a property to open the modal with the emojis, but show a Loading while the emojis are loading (not all emojis of course).
something like:
The text was updated successfully, but these errors were encountered: