Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property to add loading inside of picker. #148

Open
matheusrgarcia opened this issue May 19, 2020 · 8 comments
Open

Property to add loading inside of picker. #148

matheusrgarcia opened this issue May 19, 2020 · 8 comments

Comments

@matheusrgarcia
Copy link

The component itself is really good, but since there are many stickers to load, it takes a time to load the component, it would be awesome to have a property to open the modal with the emojis, but show a Loading while the emojis are loading (not all emojis of course).

something like:

<Picker showLoading={true} />

example

@ealush
Copy link
Owner

ealush commented May 20, 2020

hey @matheus-garcia
I am wondering at which stage do you see the need in this feature?

Because definitely we don't want to be waiting for all 1500+ emojis to be rendered. Would the initial group suffice in your opinion?

@matheusrgarcia
Copy link
Author

Yes, any group loaded would remove the loading screen.

@ealush
Copy link
Owner

ealush commented May 28, 2020

So this requires some work, and in some ways is related to the lagging search issue #133 . Since I batch-render everything at once I don't really have an easy to set and stop the loader. I'll have to make some changes to introduce that. In the meantime I'll add some other small perf wins to at least make it feel a little better.

@ealush
Copy link
Owner

ealush commented Jun 1, 2020

@matheus-garcia I just released version 3.2 which slightly improved the perceived performance of the initial load. It is not a game changer, it just attempts to load the first category before rendering all the rest. It might help until I actually implement something more sophisticated.

@matheusrgarcia
Copy link
Author

Thanks, I'll check it out :)

@avi-l
Copy link

avi-l commented Oct 25, 2021

I'd like to vote for this feature as well

@ealush
Copy link
Owner

ealush commented Dec 11, 2021

Let's add this for a new version tracking. Not sure how an API would look like, probably give you the ability to provide a custom spinner.

@avi-l
Copy link

avi-l commented Jan 25, 2022

Let's add this for a new version tracking. Not sure how an API would look like, probably give you the ability to provide a custom spinner.

A skeleton loader would probably look best. Please implement this feature soon, as the user will think nothing is happening after they click to open this emoji picker and there is no visual indication that something is happening. it takes 2 seconds for me between clicking and something showing up on the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants