fix(vest): prevent performing eager check on prev test run

ealush · Mar 1, 2022 · 24bc521 · 24bc521 · vercel · Mar 1, 2022
1 parent 579b241
commit 24bc521
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/packages/vest/src/core/test/lib/registerPrevRunTest.ts b/packages/vest/src/core/test/lib/registerPrevRunTest.ts
@@ -13,14 +13,12 @@ import { useTestAtCursor, useSetTestAtCursor } from 'useTestAtCursor';
 
 // eslint-disable-next-line max-statements
 export default function registerPrevRunTest(testObject: VestTest): VestTest {
-  const prevRunTest = useTestAtCursor(testObject);
-
   if (shouldSkipBasedOnMode(testObject)) {
-    testCursor.moveForward();
     testObject.skip();
-    return testObject;
   }
 
+  const prevRunTest = useTestAtCursor(testObject);
+
   if (isOmitted()) {
     prevRunTest.omit();
     testCursor.moveForward();

diff --git a/packages/vest/src/hooks/mode/__tests__/eager.test.ts b/packages/vest/src/hooks/mode/__tests__/eager.test.ts
@@ -101,4 +101,29 @@ describe('mode: eager', () => {
       expect(suite.get().errorCount).toBe(6);
     });
   });
+
+  describe('When test used to fail and it now passes', () => {
+    let run = 0;
+    beforeEach(() => {
+      suite = create(() => {
+        dummyTest.passing('field_1');
+
+        if (run === 0) {
+          dummyTest.failing('field_1', 'second-of-field_1');
+        } else {
+          dummyTest.passing('field_1');
+        }
+        run++;
+      });
+    });
+
+    it('Should treat test as passing', () => {
+      suite();
+      expect(suite.get().hasErrors()).toBe(true);
+      expect(suite.get().getErrors('field_1')).toEqual(['second-of-field_1']);
+      suite();
+      expect(suite.get().hasErrors()).toBe(false);
+      expect(suite.get().getErrors('field_1')).toEqual([]);
+    });
+  });
 });