tests: oneOf

ealush · Mar 31, 2022 · 2fcf0c9 · 2fcf0c9
1 parent 1c13dc0
commit 2fcf0c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/packages/n4s/src/plugins/compounds/__tests__/oneOf.test.ts b/packages/n4s/src/plugins/compounds/__tests__/oneOf.test.ts
@@ -7,13 +7,7 @@ import 'compounds';
 describe('enforce.oneOf', () => {
   it('Should fail when multiple enforcements are met', () => {
     expect(
-      User.run({
-        id: 11,
-        name: {
-          first: 'John',
-          last: 'Doe',
-        },
-      })
+      enforce.oneOf(enforce.isNumber(), enforce.greaterThan(2)).run(3)
     ).toEqual(ruleReturn.failing());
   });
 

diff --git a/packages/n4s/src/plugins/compounds/oneOf.ts b/packages/n4s/src/plugins/compounds/oneOf.ts
@@ -9,15 +9,15 @@ const REQUIRED_COUNT = 1;
 export function oneOf(value: unknown, ...rules: Lazy[]): RuleDetailedResult {
   const passing: RuleDetailedResult[] = [];
   rules.some(rule => {
-    if (longerThan(passing, REQUIRED_COUNT)) {
-      return false;
-    }
-
     const res = runLazyRule(rule, value);
 
     if (res.pass) {
       passing.push(res);
     }
+
+    if (longerThan(passing, REQUIRED_COUNT)) {
+      return false;
+    }
   });
 
   return ruleReturn(lengthEquals(passing, REQUIRED_COUNT));