# This is a combination of 2 commits.

# This is the 1st commit message: patch(vest): getFailures uses static summary object # The commit message #2 will be skipped: # initial commit
ealush · Mar 28, 2022 · 31727a0 · 31727a0
1 parent 3f9811e
commit 31727a0
Show file tree

Hide file tree

Showing 14 changed files with 235 additions and 251 deletions.
diff --git a/packages/vest/src/core/ctx/ctx.ts b/packages/vest/src/core/ctx/ctx.ts
@@ -7,6 +7,7 @@ import { IsolateKeys, IsolateTypes } from 'IsolateTypes';
 import { Modes } from 'Modes';
 import VestTest from 'VestTest';
 import type { TStateRef } from 'createStateRef';
+import { SuiteSummary } from 'genTestsSummary';
 
 export default createContext<CTXType>((ctxRef, parentContext) =>
   parentContext
@@ -59,4 +60,5 @@ type CTXType = {
     };
     emit: (event: string, ...args: any[]) => void;
   };
+  summary?: SuiteSummary;
 };
diff --git a/packages/vest/src/core/suite/produce/__tests__/produce.test.ts b/packages/vest/src/core/suite/produce/__tests__/produce.test.ts
@@ -52,6 +52,7 @@ describe.each(Object.keys(methods))('produce method: %s', methodName => {
       expect(produceMethod().hasWarnings('field_5')).toBe(true);
       expect(produceMethod().getErrors()).toEqual({
         field_1: ['message', 'failure_message', 'failure_message with group'],
+        field_2: [],
         field_3: ['msg'],
       });
       expect(produceMethod().getWarnings()).toEqual({

diff --git a/packages/vest/src/core/suite/produce/genTestsSummary.ts b/packages/vest/src/core/suite/produce/genTestsSummary.ts
@@ -126,7 +126,7 @@ export type SuiteSummary = {
   valid: boolean;
 } & SummaryBase;
 
-type TestGroup = Record<string, SingleTestSummary>;
+export type TestGroup = Record<string, SingleTestSummary>;
 
 type SingleTestSummary = SummaryBase & {
   errors: string[];

diff --git a/...ore/suite/produce/getFailures/__tests__/__snapshots__/collectFailureMessages.test.ts.snap b/...ore/suite/produce/getFailures/__tests__/__snapshots__/collectFailureMessages.test.ts.snap
@@ -10,6 +10,9 @@ Object {
     "field_2_failure message 1",
     "field_2_failure message 3",
   ],
+  "field_3": Array [],
+  "v": Array [],
+  "x": Array [],
 }
 `;
 
@@ -36,6 +39,7 @@ Object {
     "field_2_failure message 1",
     "field_2_failure message 3",
   ],
+  "field_3": Array [],
 }
 `;
 
@@ -52,10 +56,14 @@ exports[`collectFailureMessages getErrorsByGroup with field name Should match sn
 
 exports[`collectFailureMessages getWarnings When no options passed should match snapshot 1`] = `
 Object {
+  "field_1": Array [],
   "field_2": Array [
     "field_2_warning message 2",
     "field_2_warning message 3",
   ],
+  "field_3": Array [],
+  "v": Array [],
+  "x": Array [],
 }
 `;
 
@@ -72,9 +80,11 @@ exports[`collectFailureMessages getWarnings When specific field requested Should
 
 exports[`collectFailureMessages getWarningsByGroup Should match snapshot 1`] = `
 Object {
+  "field_1": Array [],
   "field_2": Array [
     "field_2_warning message 3",
   ],
+  "field_3": Array [],
 }
 `;
 

diff --git a/packages/vest/src/core/suite/produce/getFailures/__tests__/collectFailureMessages.test.ts b/packages/vest/src/core/suite/produce/getFailures/__tests__/collectFailureMessages.test.ts
@@ -1,9 +1,6 @@
 // TODO: Verify this test file is not needed and delete it
 import { dummyTest } from '../../../../../../testUtils/testDummy';
 
-import { Severity } from 'Severity';
-import VestTest from 'VestTest';
-import collectFailureMessages from 'collectFailureMessages';
 import create from 'create';
 import group from 'group';
 import { SuiteResult } from 'produceSuiteResult';
@@ -26,6 +23,7 @@ describe('collectFailureMessages', () => {
     expect(result).toEqual({
       field_1: [],
       field_2: ['field_2_failure message 1', 'field_2_failure message 3'],
+      field_3: [],
     });
   });
 
@@ -34,13 +32,7 @@ describe('collectFailureMessages', () => {
   });
 
   it('Should return an object with an empty array when selected field has no errors', () => {
-    expect(
-      collectFailureMessages(
-        Severity.ERRORS,
-        [new VestTest('field_1', jest.fn(), { message: 'error_message' })],
-        { fieldName: 'field_1' }
-      )
-    ).toEqual({ field_1: [] });
+    expect(res.getErrors('v')).toEqual([]);
   });
 
   describe('getErrors', () => {
@@ -120,6 +112,11 @@ describe('collectFailureMessages', () => {
         'group_1'
       );
       dummyTest.failing('field_2', 'field_2_failure message 3', 'group_1');
+      dummyTest.passing('v');
+
+      group('group_2', () => {
+        dummyTest.passing('x');
+      });
     });
     suite();
     res = suite.get();

diff --git a/packages/vest/src/core/suite/produce/getFailures/__tests__/getFailures.test.ts b/packages/vest/src/core/suite/produce/getFailures/__tests__/getFailures.test.ts
@@ -28,9 +28,12 @@ describe.each(Object.keys(methods))('produce method: %s', methodName => {
     });
     describe('When no errors', () => {
       describe('When no parameters passed', () => {
-        itWithContext('Should return an empty object', () => {
-          setTestObjects(dummyTest.passing(), dummyTest.passing());
-          expect(produceMethod().getErrors()).toEqual({});
+        itWithContext('Should return an object with empty error arrays', () => {
+          setTestObjects(dummyTest.passing('f1'), dummyTest.passing('f2'));
+          expect(produceMethod().getErrors()).toEqual({
+            f1: [],
+            f2: [],
+          });
         });
       });
       describe('When requesting a fieldName', () => {
@@ -88,8 +91,11 @@ describe.each(Object.keys(methods))('produce method: %s', methodName => {
     describe('When no warnings', () => {
       describe('When no parameters passed', () => {
         itWithContext('Should return an empty object', () => {
-          setTestObjects(dummyTest.passing(), dummyTest.passing());
-          expect(produceMethod().getWarnings()).toEqual({});
+          setTestObjects(dummyTest.passing('x'), dummyTest.passing('y'));
+          expect(produceMethod().getWarnings()).toEqual({
+            x: [],
+            y: [],
+          });
         });
       });
       describe('When requesting a fieldName', () => {