chore: improve anyone code coverage

ealush · Aug 8, 2022 · 3f18579 · 3f18579 · vercel · Aug 8, 2022
1 parent b286f4b
commit 3f18579
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/packages/anyone/src/__tests__/runAnyoneMethods.test.ts b/packages/anyone/src/__tests__/runAnyoneMethods.test.ts
@@ -28,4 +28,14 @@ describe('lib/run', () => {
       );
     });
   });
+
+  describe('When the function throws an error', () => {
+    it('Should return false', () => {
+      expect(
+        run(() => {
+          throw new Error();
+        })
+      ).toBe(false);
+    });
+  });
 });
diff --git a/packages/anyone/src/runner/runAnyoneMethods.ts b/packages/anyone/src/runner/runAnyoneMethods.ts
@@ -17,5 +17,5 @@ export default function run(arg: unknown): boolean {
 
 function check(value: unknown): boolean {
   // We use abstract equality intentionally here. This enables falsy valueOf support.
-  return Array.isArray(value) ? true : value != false && Boolean(value); // eslint-disable-line
+  return Array.isArray(value) ? true : value != false && Boolean(value);
 }
diff --git a/packages/n4s/src/runtime/enforceContext.ts b/packages/n4s/src/runtime/enforceContext.ts
@@ -22,7 +22,7 @@ export const ctx = createCascade<CTXType>((ctxRef, parentContext): CTXType => {
 
 function stripContext(ctx: null | CTXType): EnforceContext {
   if (!ctx) {
-    return ctx;
+    return null;
   }
 
   return {

diff --git a/...tors/__tests__/hasFailuresByTestObject.ts → ...__tests__/hasFailuresByTestObject.test.ts b/...tors/__tests__/hasFailuresByTestObject.ts → ...__tests__/hasFailuresByTestObject.test.ts
diff --git a/packages/vest/src/core/test/runAsyncTest.ts b/packages/vest/src/core/test/runAsyncTest.ts
@@ -32,11 +32,6 @@ export default function runAsyncTest(testObject: VestTest): void {
 
     done();
   });
-  try {
-    asyncTest.then(done, fail);
-  } catch (e) {
-    // We will probably never get here, unless the consumer uses a buggy custom Promise
-    // implementation that behaves differently than the native one, or if they for some
-    fail();
-  }
+
+  asyncTest.then(done, fail);
 }