lint: ignore comments in max-lines

ealush · Jul 15, 2022 · 47d688a · 47d688a · vercel · Jul 15, 2022
1 parent a9070d9
commit 47d688a
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -24,7 +24,7 @@ module.exports = {
       excludedFiles: ['./**/__tests__/**/*.*'],
       rules: {
         'max-depth': [1, { max: 3 }],
-        'max-lines-per-function': [1, { max: 45 }],
+        'max-lines-per-function': [1, { max: 45, skipComments: true }],
         'max-nested-callbacks': [1, { max: 2 }],
         'max-statements': [1, { max: 10 }],
       },

diff --git a/packages/n4s/src/runtime/enforceEager.ts b/packages/n4s/src/runtime/enforceEager.ts
@@ -8,7 +8,6 @@ import { transformResult } from 'transformResult';
 
 type IRules = n4s.IRules<Record<string, any>>;
 
-// eslint-disable-next-line max-lines-per-function
 export default function enforceEager(value: RuleValue): IRules {
   const target = {} as IRules;
 

diff --git a/packages/vest/src/core/test/test.memo.ts b/packages/vest/src/core/test/test.memo.ts
@@ -6,7 +6,7 @@ import { useCursor } from 'isolateHooks';
 import registerPrevRunTest from 'registerPrevRunTest';
 import { useSuiteId } from 'stateHooks';
 import type { TestBase } from 'test';
-// eslint-disable-next-line max-lines-per-function
+
 export default function bindTestMemo(test: TestBase): {
   (fieldName: string, test: TestFn, deps: unknown[]): VestTest;
   (fieldName: string, message: string, test: TestFn, deps: unknown[]): VestTest;

diff --git a/packages/vest/src/exports/parser.ts b/packages/vest/src/exports/parser.ts
@@ -3,7 +3,7 @@ import { hasOwnProperty, invariant, isPositive } from 'vest-utils';
 
 import { SuiteSummary } from 'SuiteSummaryTypes';
 
-// eslint-disable-next-line max-lines-per-function, max-statements
+// eslint-disable-next-line max-statements
 export function parse(summary: SuiteSummary): ParsedVestObject {
   invariant(
     summary && hasOwnProperty(summary, 'valid'),

diff --git a/packages/vest/src/hooks/exclusive.ts b/packages/vest/src/hooks/exclusive.ts
@@ -42,7 +42,7 @@ skip.group = (item: ExclusionItem) =>
 
 //Checks whether a certain test profile excluded by any of the exclusion groups.
 
-// eslint-disable-next-line complexity, max-statements, max-lines-per-function
+// eslint-disable-next-line complexity, max-statements
 export function isExcluded(testObject: VestTest): boolean {
   const { fieldName, groupName } = testObject;