fix(vest): prevent changing test status once it was finalized

ealush · Nov 10, 2021 · 4d450aa · 4d450aa
1 parent 8730e25
commit 4d450aa
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 2 deletions.
diff --git a/packages/vest/src/core/test/VestTest.ts b/packages/vest/src/core/test/VestTest.ts
@@ -50,7 +50,7 @@ export default class VestTest {
   }
 
   setStatus(status: KStatus): void {
-    if (this.isCanceled()) {
+    if (this.isFinalStatus()) {
       return;
     }
 
@@ -66,7 +66,7 @@ export default class VestTest {
   }
 
   done(): void {
-    if (this.isWarning() || this.isCanceled() || this.isFailing()) {
+    if (this.isFinalStatus()) {
       return;
     }
     this.setStatus(STATUS_PASSING);
@@ -76,6 +76,10 @@ export default class VestTest {
     this.warns = true;
   }
 
+  isFinalStatus(): boolean {
+    return this.hasFailures() || this.isCanceled() || this.isPassing();
+  }
+
   skip(): void {
     this.setStatus(STATUS_SKIPPED);
   }

diff --git a/packages/vest/src/core/test/lib/__tests__/VestTest.test.ts b/packages/vest/src/core/test/lib/__tests__/VestTest.test.ts
@@ -107,5 +107,40 @@ describe('VestTest', () => {
         expect(allIncomplete).toEqual(expect.not.arrayContaining([testObject]));
       }
     });
+
+    describe('final statuses', () => {
+      let testObject, fn;
+      beforeEach(() => {
+        fn = jest.fn();
+        testObject = new VestTest('field', fn);
+      });
+      itWithContext('keep status unchanged when `failed`', () => {
+        testObject.fail();
+        expect(testObject.isFailing()).toBe(true);
+        testObject.skip();
+        expect(testObject.isSkipped()).toBe(false);
+        expect(testObject.isFailing()).toBe(true);
+        testObject.cancel();
+        expect(testObject.isCanceled()).toBe(false);
+        expect(testObject.isFailing()).toBe(true);
+        testObject.setPending();
+        expect(testObject.isPending()).toBe(false);
+        expect(testObject.isFailing()).toBe(true);
+      });
+
+      itWithContext('keep status unchanged when `canceled`', () => {
+        testObject.setStatus('CANCELED');
+        expect(testObject.isCanceled()).toBe(true);
+        testObject.fail();
+        expect(testObject.isCanceled()).toBe(true);
+        expect(testObject.isFailing()).toBe(false);
+        testObject.skip();
+        expect(testObject.isSkipped()).toBe(false);
+        expect(testObject.isCanceled()).toBe(true);
+        testObject.setPending();
+        expect(testObject.isPending()).toBe(false);
+        expect(testObject.isCanceled()).toBe(true);
+      });
+    });
   });
 });