patch: use fieldCallbacks as an object

ealush · May 11, 2021 · 73f2e35 · 73f2e35
1 parent 94dd7a5
commit 73f2e35
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/packages/vest/src/core/produce/genTestsSummary.js b/packages/vest/src/core/produce/genTestsSummary.js
@@ -16,9 +16,12 @@ const genTestsSummary = () => {
   const [skippedTests] = useSkippedTests();
 
   const summary = {
-    tests: {},
+    [SEVERITY_COUNT_ERROR]: 0,
+    [SEVERITY_COUNT_WARN]: 0,
+    [TEST_COUNT]: 0,
     groups: {},
     name: suiteIdState.name,
+    tests: {},
   };
 
   appendSummary(testObjects);
@@ -53,10 +56,6 @@ const genTestsSummary = () => {
  * @param {Object} summary (generated by genTestsSummary)
  */
 export const countFailures = summary => {
-  summary[SEVERITY_COUNT_ERROR] = 0;
-  summary[SEVERITY_COUNT_WARN] = 0;
-  summary[TEST_COUNT] = 0;
-
   for (const test in summary.tests) {
     summary[SEVERITY_COUNT_ERROR] += summary.tests[test][SEVERITY_COUNT_ERROR];
     summary[SEVERITY_COUNT_WARN] += summary.tests[test][SEVERITY_COUNT_WARN];

diff --git a/packages/vest/src/core/state/createStateRef.js b/packages/vest/src/core/state/createStateRef.js
@@ -7,7 +7,7 @@ export default function createStateRef(state, { suiteId, name }) {
     skippedTests: state.registerStateKey(() => []),
     suiteId: state.registerStateKey(() => ({ id: suiteId, name })),
     testCallbacks: state.registerStateKey(() => ({
-      fieldCallbacks: [],
+      fieldCallbacks: {},
       doneCallbacks: [],
     })),
     testObjects: state.registerStateKey(() => []),

diff --git a/packages/vest/src/core/test/lib/__tests__/__snapshots__/pending.test.js.snap b/packages/vest/src/core/test/lib/__tests__/__snapshots__/pending.test.js.snap
@@ -13,7 +13,7 @@ Object {
   },
   "testCallbacks": Object {
     "doneCallbacks": Array [],
-    "fieldCallbacks": Array [],
+    "fieldCallbacks": Object {},
   },
   "testObjects": Array [],
 }
@@ -32,7 +32,7 @@ Object {
   },
   "testCallbacks": Object {
     "doneCallbacks": Array [],
-    "fieldCallbacks": Array [],
+    "fieldCallbacks": Object {},
   },
   "testObjects": Array [],
 }
@@ -61,7 +61,7 @@ Object {
   },
   "testCallbacks": Object {
     "doneCallbacks": Array [],
-    "fieldCallbacks": Array [],
+    "fieldCallbacks": Object {},
   },
   "testObjects": Array [],
 }
@@ -107,7 +107,7 @@ Object {
   },
   "testCallbacks": Object {
     "doneCallbacks": Array [],
-    "fieldCallbacks": Array [],
+    "fieldCallbacks": Object {},
   },
   "testObjects": Array [],
 }