tests(vest): isValid

ealush · Apr 1, 2022 · b20ef64 · b20ef64
1 parent 8a20841
commit b20ef64
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 2 deletions.
diff --git a/packages/vest/src/core/suite/produce/summarySelectors/__tests__/isValid.test.ts b/packages/vest/src/core/suite/produce/summarySelectors/__tests__/isValid.test.ts
@@ -33,6 +33,14 @@ describe('isValid', () => {
     it('Should return false when a required test has errors', () => {
       expect(suite('field_1').isValid()).toBe(false);
     });
+
+    it('Should return false when the queried field is not optional and has errors', () => {
+      expect(suite('field_2').isValid('field_2')).toBe(false);
+    });
+
+    it('Should return true when the queried field is optional and has errors', () => {
+      expect(suite('field_1').isValid('field_1')).toBe(true);
+    });
   });
 
   describe('When there are warnings in the suite', () => {
@@ -48,6 +56,7 @@ describe('isValid', () => {
     });
     it('Should return true when a required test has warnings', () => {
       expect(suite().isValid()).toBe(true);
+      expect(suite().isValid('field_1')).toBe(true);
     });
 
     describe('When some of the tests for the required field are warnings', () => {
@@ -125,13 +134,15 @@ describe('isValid', () => {
       it('Should return true', () => {
         suite();
         expect(suite.get().isValid()).toBe(true);
+        expect(suite.get().isValid('field_1')).toBe(true);
       });
     });
     describe('When test is passing', () => {
       it('Should return true', async () => {
         suite();
         await wait(300);
         expect(suite.get().isValid()).toBe(true);
+        expect(suite.get().isValid('field_1')).toBe(true);
       });
     });
   });
@@ -158,6 +169,13 @@ describe('isValid', () => {
       await wait(300);
       expect(suite.get().isValid()).toBe(true);
     });
+
+    it('Should return false as long as the test is pending when querying a specific field', async () => {
+      suite();
+      expect(suite.get().isValid('field_1')).toBe(false);
+      await wait(300);
+      expect(suite.get().isValid('field_1')).toBe(true);
+    });
   });
 
   describe('When the suite has async non-optional tests', () => {
@@ -181,6 +199,7 @@ describe('isValid', () => {
         const result = suite();
 
         expect(result.isValid()).toBe(false);
+        expect(result.isValid('field_1')).toBe(false);
       });
     });
 
@@ -189,6 +208,8 @@ describe('isValid', () => {
         return new Promise<void>(done => {
           suite().done(result => {
             expect(result.isValid()).toBe(true);
+            expect(result.isValid('field_1')).toBe(true);
+            expect(result.isValid('field_2')).toBe(true);
             done();
           });
         });
@@ -226,6 +247,9 @@ describe('isValid', () => {
     });
     it('Should return true', () => {
       expect(suite().isValid()).toBe(true);
+      expect(suite().isValid('field_1')).toBe(true);
+      expect(suite().isValid('field_2')).toBe(true);
+      expect(suite().isValid('field_3')).toBe(true);
     });
   });
 
@@ -319,4 +343,14 @@ describe('isValid', () => {
       ).toBe(true);
     });
   });
+
+  describe('When querying a non existing field', () => {
+    it('Should return false', () => {
+      expect(
+        create(() => {
+          test('field_1', () => true);
+        })().isValid('field_2')
+      ).toBe(false);
+    });
+  });
 });
diff --git a/packages/vest/src/core/suite/produce/summarySelectors/isValid.ts b/packages/vest/src/core/suite/produce/summarySelectors/isValid.ts
@@ -3,5 +3,5 @@ import { useSummary } from 'genTestsSummary';
 export function isValid(fieldName?: string): boolean {
   const summary = useSummary();
 
-  return Boolean(fieldName ? summary.tests?.[fieldName]?.valid : summary.valid);
+  return fieldName ? Boolean(summary.tests[fieldName]?.valid) : summary.valid;
 }
diff --git a/packages/vest/src/core/test/__tests__/memo.test.ts b/packages/vest/src/core/test/__tests__/memo.test.ts
@@ -74,7 +74,7 @@ describe('test.memo', () => {
     });
 
     describe('async', () => {
-      it('Should immediately previous result on re-run', async () => {
+      it('Should immediately return previous result on re-run', async () => {
         {
           const suite = promisify(
             vest.create(() => {