types(vest): fix promisify types (#563)

ealush · Jan 21, 2021 · d566a32 · d566a32
1 parent 20a047b
commit d566a32
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/packages/vest/src/__tests__/test_types/fixtures/suite.ts b/packages/vest/src/__tests__/test_types/fixtures/suite.ts
@@ -1,3 +1,5 @@
+import promisify from 'vest/promisify';
+
 import vest from 'vest';
 
 vest.create('suite_name', () => {});
@@ -91,3 +93,7 @@ getResult.tests.someField.warnCount;
 getResult.tests.someField.testCount;
 getResult.tests.someField.errors[0];
 getResult.tests.someField.warnings[0];
+
+const promisified = promisify(v);
+
+promisified({}).then(() => {});
diff --git a/packages/vest/src/typings/promisify.d.ts b/packages/vest/src/typings/promisify.d.ts
@@ -2,6 +2,6 @@ import { IVestResult, DraftResult } from './vestResult';
 
 declare function promisify(
   validatorFn: (...args: any[]) => IVestResult
-): Promise<DraftResult>;
+): (...args: any[]) => Promise<DraftResult>;
 
 export default promisify;
diff --git a/packages/vest/src/typings/vestResult.d.ts b/packages/vest/src/typings/vestResult.d.ts
@@ -1,6 +1,6 @@
 type DoneCB = (res: DraftResult) => void;
 
-export type IVestResult = {
+export type DraftResult = {
   name: string;
   errorCount: number;
   warnCount: number;
@@ -83,14 +83,17 @@ export type IVestResult = {
    * Returns all the warning messages for the specified group and field
    */
   getWarningsByGroup(groupName: string, fieldName: string): string[];
+};
+
+type DoneResult = {
   /**
-   * Runs a callback when all tests are finished running
+   * Runs a callback when all tests of the specified field finished running
    */
-  done(cb: DoneCB): void;
+  done(fieldName: string, cb: DoneCB): IVestResult;
   /**
-   * Runs a callback when all tests of the specified field finished running
+   * Runs a callback when all tests are finished running
    */
-  done(fieldName: string, cb: DoneCB): void;
+  done(cb: DoneCB): IVestResult;
 };
 
-export type DraftResult = Omit<IVestResult, 'done'>;
+export interface IVestResult extends DoneResult, DraftResult {}