simpler changed package detection

ealush · Aug 14, 2022 · f6d703b · f6d703b
1 parent 861ddd6
commit f6d703b
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 563 deletions.
diff --git a/packages/n4s/src/exports/compose.ts b/packages/n4s/src/exports/compose.ts
@@ -1,7 +1,7 @@
-import { ctx } from 'n4s';
 import { invariant, StringObject, assign, mapFirst } from 'vest-utils';
 
 import type { ComposeResult, LazyRuleRunners } from 'genEnforceLazy';
+import { ctx } from 'n4s';
 import { defaultToPassing, RuleDetailedResult } from 'ruleReturn';
 import runLazyRule from 'runLazyRule';
 

diff --git a/packages/n4s/src/exports/compounds.ts b/packages/n4s/src/exports/compounds.ts
@@ -1,9 +1,8 @@
-import { enforce } from 'n4s';
-
 import { allOf } from 'allOf';
 import { anyOf } from 'anyOf';
 import { EnforceCustomMatcher } from 'enforceUtilityTypes';
 import { Lazy } from 'genEnforceLazy';
+import { enforce } from 'n4s';
 import { noneOf } from 'noneOf';
 import { oneOf } from 'oneOf';
 import { RuleDetailedResult } from 'ruleReturn';

diff --git a/packages/n4s/src/exports/schema.ts b/packages/n4s/src/exports/schema.ts
@@ -1,8 +1,7 @@
-import { enforce } from 'n4s';
-
 import { EnforceCustomMatcher } from 'enforceUtilityTypes';
 import { isArrayOf } from 'isArrayOf';
 import { loose } from 'loose';
+import { enforce } from 'n4s';
 import { optional } from 'optional';
 import { shape } from 'shape';
 

diff --git a/packages/n4s/src/plugins/schema/isArrayOf.ts b/packages/n4s/src/plugins/schema/isArrayOf.ts
@@ -1,7 +1,7 @@
-import { ctx } from 'n4s';
 import { mapFirst } from 'vest-utils';
 
 import type { LazyRuleRunners } from 'genEnforceLazy';
+import { ctx } from 'n4s';
 import type { RuleDetailedResult } from 'ruleReturn';
 import * as ruleReturn from 'ruleReturn';
 import runLazyRule from 'runLazyRule';

diff --git a/packages/n4s/src/plugins/schema/loose.ts b/packages/n4s/src/plugins/schema/loose.ts
@@ -1,5 +1,4 @@
 import { ctx } from 'n4s';
-
 import type { RuleDetailedResult } from 'ruleReturn';
 import * as ruleReturn from 'ruleReturn';
 import runLazyRule from 'runLazyRule';

diff --git a/vx/scripts/release/github/listAllChangedPackages.js b/vx/scripts/release/github/listAllChangedPackages.js
@@ -1,7 +1,5 @@
-const path = require('path');
-
-const opts = require('vx/opts');
 const packageNames = require('vx/packageNames');
+const vxPath = require('vx/vxPath');
 
 const listAllChangesSinceStableBranch = require('./listAllChangesSinceStableBranch');
 
@@ -10,12 +8,7 @@ function listAllChangedPackages() {
   return Object.keys(
     changes.reduce((packages, { files = [] }) => {
       return files.reduce((packages, file) => {
-        if (!file.startsWith(opts.dir.PACKAGES)) {
-          return packages;
-        }
-
-        const [, packageName] = file.split(path.sep);
-
+        const packageName = vxPath.packageNameFromPath(file);
         if (!packageNames.names[packageName]) {
           return packages;
         }