Support Linux without requiring external dependency (xclip) #394
Conversation
package.json
Outdated
| @@ -397,7 +397,7 @@ | |||
| }, | |||
| "gitlens.explorers.commitFormat": { | |||
| "type": "string", | |||
| "default": "${message} \u00a0\u2022\u00a0 ${authorAgoOrDate} \u00a0 (${id})", | |||
| "default": "${message} • ${authorAgoOrDate} (${id})", | |||
There was a problem hiding this comment.
NPM did all those changes automatically with npm install. I can revert them if requested, but it should happen to everyone doing npm install?
There was a problem hiding this comment.
Yes, please revert any changes that aren't absolutely required. Sadly the package.json rewriting by npm is a constant source of pain (but if the changes are allowed it screws up the encoding of the file and causes other issues across platforms). I typically just run npm install --no-save to avoid that rewriting, but obviously you can't if you are adding/updating a package. Its a total PITA, sorry.
|
Awesome! Thank you for this -- I've been meaning to get around to switching over to clipboardy 👍 |
package.json
Outdated
| "postinstall": "node ./node_modules/vscode/bin/install && pushd \"./src/ui\" && npm install --no-save && popd", | ||
| "prepush": "npm run build", | ||
| "vscode:prepublish": "npm run reset && npm run bundle" | ||
| }, | ||
| "dependencies": { | ||
| "copy-paste": "1.3.0", | ||
| "clipboardy": "^1.2.3", |
There was a problem hiding this comment.
Please remove the ^ -- I like to have the dependencies locked down for reproducible builds
package.json
Outdated
| @@ -3241,7 +3340,7 @@ | |||
| "tslib": "1.9.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/copy-paste": "1.1.30", | |||
| "@types/clipboardy": "^1.1.0", | |||
|
Also please target the |
cmalard
force-pushed
the
clipboardy
branch
3 times, most recently
from
aafd588
to
ed4928b
Compare
|
👍 |
|
Awesome! Thanks for you contribution! |
I replaced copy-paste by clipboardy.
Ref #35