Added unit test for covarage (flyteorg#83)

Signed-off-by: Yuvraj <code@evalsocket.dev>

flytectl/.github/workflows/build.yaml

@@ -2,7 +2,8 @@ name: build
 
 on:
   pull_request:
-  push:
+    branches:
+      - master
 
 jobs:
   build:
@@ -23,7 +24,7 @@ jobs:
         with:
           args: make install && make test_unit_codecov
       - name: Push CodeCov
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v1.0.5
         with:
           file: coverage.txt
           flags: unittests

flytectl/.gitignore

@@ -5,5 +5,4 @@ bin
 .DS_Store
 _test
 ./config.yaml
-docs/build/*
-cmd/get/temp-output-file
+docs/build/*

flytectl/cmd/config/config_test.go

@@ -0,0 +1,32 @@
+package config
+
+import (
+	"testing"
+
+	"github.com/flyteorg/flytectl/pkg/printer"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestOutputFormat(t *testing.T) {
+	c := &Config{
+		Output: "json",
+	}
+	result, err := c.OutputFormat()
+	assert.Nil(t, err)
+	assert.Equal(t, printer.OutputFormat(1), result)
+}
+
+func TestInvalidOutputFormat(t *testing.T) {
+	c := &Config{
+		Output: "test",
+	}
+	var result printer.OutputFormat
+	defer func() {
+		if r := recover(); r != nil {
+			assert.Equal(t, printer.OutputFormat(0), result)
+			assert.NotNil(t, r)
+		}
+	}()
+	result = c.MustOutputFormat()
+
+}

flytectl/cmd/config/subcommand/matchable_attr_file_config_utils.go

@@ -17,7 +17,7 @@ func WriteConfigToFile(matchableAttrConfig interface{}, fileName string) error {
 		return fmt.Errorf("error: %v", err)
 	}
 	if _, err = os.Stat(fileName); err == nil {
-		if !cmdUtil.AskForConfirmation(fmt.Sprintf("warning file %v will be overwritten", fileName)) {
+		if !cmdUtil.AskForConfirmation(fmt.Sprintf("warning file %v will be overwritten", fileName), os.Stdin) {
 			return fmt.Errorf("backup the file before continuing")
 		}
 	}

flytectl/cmd/get/execution_util.go

@@ -33,7 +33,7 @@ func WriteExecConfigToFile(executionConfig ExecutionConfig, fileName string) err
 		fmt.Printf("error: %v", err)
 	}
 	if _, err = os.Stat(fileName); err == nil {
-		if !cmdUtil.AskForConfirmation(fmt.Sprintf("warning file %v will be overwritten", fileName)) {
+		if !cmdUtil.AskForConfirmation(fmt.Sprintf("warning file %v will be overwritten", fileName), os.Stdin) {
 			return errors.New("backup the file before continuing")
 		}
 	}

flytectl/cmd/get/launch_plan.go

@@ -75,7 +75,7 @@ Retrieves a launch plans within project and domain for a version and generate th
 
 ::
 
- flytectl get launchplan -d development -p flytectldemo core.advanced.run_merge_sort.merge_sort --execFile execution_spec.yam
+ flytectl get launchplan -d development -p flytectldemo core.advanced.run_merge_sort.merge_sort --execFile execution_spec.yaml
 
 The generated file would look similar to this
 
@@ -152,9 +152,6 @@ func getLaunchPlanFunc(ctx context.Context, args []string, cmdCtx cmdCore.Comman
 		return err
 	}
 	launchPlans := launchPlanList.LaunchPlans
-	if err != nil {
-		return err
-	}
 	logger.Debugf(ctx, "Retrieved %v launch plans", len(launchPlans))
 	return launchPlanPrinter.Print(config.GetConfig().MustOutputFormat(), launchplansColumns,
 		LaunchplanToProtoMessages(launchPlans)...)

flytectl/cmd/root.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"fmt"
 
+	f "github.com/flyteorg/flytectl/pkg/filesystemutils"
+
 	"github.com/flyteorg/flytectl/cmd/config"
 	cmdCore "github.com/flyteorg/flytectl/cmd/core"
 	"github.com/flyteorg/flytectl/cmd/create"
@@ -12,7 +14,6 @@ import (
 	"github.com/flyteorg/flytectl/cmd/register"
 	"github.com/flyteorg/flytectl/cmd/update"
 	"github.com/flyteorg/flytectl/cmd/version"
-	f "github.com/flyteorg/flytectl/pkg/filesystemutils"
 	"github.com/flyteorg/flytectl/pkg/printer"
 	stdConfig "github.com/flyteorg/flytestdlib/config"
 	"github.com/flyteorg/flytestdlib/config/viper"
@@ -41,7 +42,7 @@ func newRootCmd() *cobra.Command {
 		DisableAutoGenTag: true,
 	}
 
-	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "",
+	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", f.FilePathJoin(f.UserHomeDir(), configFileDir, configFileName),
 		"config file (default is $HOME/.flyte/config.yaml)")
 
 	configAccessor.InitializePflags(rootCmd.PersistentFlags())
@@ -69,7 +70,7 @@ func newRootCmd() *cobra.Command {
 func initConfig(_ *cobra.Command, _ []string) error {
 	configAccessor = viper.NewAccessor(stdConfig.Options{
 		StrictMode:  true,
-		SearchPaths: []string{cfgFile, f.FilePathJoin(f.UserHomeDir(), configFileDir, configFileName)},
+		SearchPaths: []string{cfgFile},
 	})
 
 	err := configAccessor.UpdateConfig(context.TODO())

flytectl/pkg/adminutils/config_test.go

@@ -0,0 +1,17 @@
+package adminutils
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetConfig(t *testing.T) {
+	defaultConfig = &Config{
+		MaxRecords: 500,
+		BatchSize:  100,
+	}
+	c := GetConfig()
+	assert.Equal(t, defaultConfig.BatchSize, c.BatchSize)
+	assert.Equal(t, defaultConfig.MaxRecords, c.MaxRecords)
+}

flytectl/pkg/commandutils/command_utils.go

@@ -3,24 +3,20 @@ package commandutils
 import (
 	"bufio"
 	"fmt"
-	"log"
-	"os"
+	"io"
 	"strings"
 )
 
-func AskForConfirmation(s string) bool {
-	reader := bufio.NewReader(os.Stdin)
-	for {
-		fmt.Printf("%s [y/n]: ", s)
-		response, err := reader.ReadString('\n')
-		if err != nil {
-			log.Fatal(err)
-		}
-		response = strings.ToLower(strings.TrimSpace(response))
+func AskForConfirmation(s string, reader io.Reader) bool {
+	fmt.Printf("%s [y/n]: ", s)
+	r := bufio.NewScanner(reader)
+	for r.Scan() {
+		response := strings.ToLower(strings.TrimSpace(r.Text()))
 		if response == "y" || response == "yes" {
 			return true
-		} else if response == "n" || response == "no" {
+		} else if response == "n" || response == "No" {
 			return false
 		}
 	}
+	return false
 }

flytectl/pkg/commandutils/command_utils_test.go

@@ -0,0 +1,51 @@
+package commandutils
+
+import (
+	"io"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+type TestCase struct {
+	Input  io.Reader `json:"input"`
+	Output bool      `json:"output"`
+}
+
+func TestAskForConfirmation(t *testing.T) {
+	tests := []TestCase{
+		{
+			Input:  strings.NewReader("yes"),
+			Output: true,
+		},
+		{
+			Input:  strings.NewReader("y"),
+			Output: true,
+		},
+		{
+			Input:  strings.NewReader("no"),
+			Output: false,
+		},
+		{
+			Input:  strings.NewReader("n"),
+			Output: false,
+		},
+		{
+			Input:  strings.NewReader("No"),
+			Output: false,
+		},
+		{
+			Input:  strings.NewReader("Yes"),
+			Output: true,
+		},
+		{
+			Input:  strings.NewReader(""),
+			Output: false,
+		},
+	}
+	for _, test := range tests {
+		answer := AskForConfirmation("Testing for yes", test.Input)
+		assert.Equal(t, test.Output, answer)
+	}
+}