espressif32 2.0.2 + 2.0.3 support #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes sound support on recent versions of espressif32 (2.0.0, 2.0.1, 2.0.2 and upcoming versions. Reason: `I2S_COMM_FORMAT_I2S` and `I2S_COMM_FORMAT_I2S_LSB` are being deprecated and respectively replaced by `I2S_COMM_FORMAT_STAND_I2S` and `I2S_COMM_FORMAT_STAND_MSB` Additionnally this disables the deprecation warning message.
|
I'll push some more changes soon, the naming is wrong and some esp-idf macros can be removed. |
|
unrelated : I've added a patch for the ESP8266 build run failing, it's using C++17 syntax though |
tobozo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken sound support with recent versions of espressif32 (2.0.0, 2.0.1, 2.0.2 and upcoming versions.
Reason:
I2S_COMM_FORMAT_I2SandI2S_COMM_FORMAT_I2S_LSBare being deprecated and respectively replaced byI2S_COMM_FORMAT_STAND_I2SandI2S_COMM_FORMAT_STAND_MSB.Additionnally this disables the deprecation warning message.