Adds definition for WIRE_INTERFACES_COUNT #1182 #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly on it can detect and use... Wire1. e.g. u8g2 will not use Wire1 unless this is (a) defined and (b) >1. This constant is defined on other cores, e.g. for SAMD based boards.
earlephilhower
requested changes
Jan 1, 2024
|
@earlephilhower thanks for letting me know! I will make the change, test and update :) |
…RE_HOWMANY which is set by... variants to indicate the number of I2Cs available to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so those libraries which rely on it can detect and use Wire1. e.g. u8g2 will not use Wire1 unless this is (a) defined and (b) >1. This constant is defined on other cores, e.g. for SAMD based boards.
This should resolve situations like that reported in #1182.
I am not entirely sure if
WIRE_INTERFACES_COUNTshould be defined incommon.h, as in other cores it is defined in variant-specific headers, e.g.https://github.com/search?q=repo%3Aarduino%2FArduinoCore-samd%20WIRE_INTERFACES_COUNT&type=code
However given that
generic/pins_arduino.hdefines pins for both I2C0 and I2C1, this doesn't seem unreasonable. i.e. the generic variant already assumes the presence of 2 I2C peripherals.