Fix Wire pin definitions on ItsyBitsy #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apendley
commented
Sep 25, 2021
apendley
commented
- Map GPIO 2 and 3 to Wire1.
- Provide sensible defaults for Wire0 (GPIO 24 and 25)
- This is the same fix that was applied for the Feather in issue Fix wire defines on feather #281.
* Map GPIO 2 and 3 to Wire1. * Provide sensible defaults for Wire0 (GPIO 24 and 25) * This is the same fix that was applied for the Feather in issue earlephilhower#281.
apendley
changed the title
|
ah, basically the same fix I submitted, except you enabled set Wire0 to GPIO 24 and 25. Yes, this is probably ideal since it is consistent with the feather. Should the #define WIRE_HOWMANY change to 2 then? Not sure it's used anywhere. |
|
Oh! I didn't realize that someone else had submitted a fix for the same issue! I was just banging my head against this tonight and remembered that the Feather had the same issue recently, so I dug into it a little. Not sure about WIRE_HOWMANY, I don't think it's used anywhere, but it probably wouldn't hurt to update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.