Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should fail when individual tests fail #256

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

RobertPincus
Copy link
Member

Small changes to scripts and in-test tolerances.

Copy link
Collaborator

@alexeedm alexeedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Tolerance might be a bit tight, but I don't know a robust way to set it. We may need to check it again when NVHPC 24.1 is released.

@skosukhin
Copy link
Collaborator

This now works with NVHPC versions 22.5, 23.7 and 23.9 (-g -O2 -Mrecursive -Mallocatable=03 -Mstack_arrays -Minfo=accel,inline -acc=gpu,verystrict -gpu=cc80) and Cray 16.0.1 (-hacc -hadd_paren -Ktrap=divz,ovf,inv -hflex_mp=intolerant -hfp1 -g).

@RobertPincus RobertPincus merged commit 9a656e0 into main Jan 25, 2024
40 of 48 checks passed
@RobertPincus RobertPincus deleted the hotfix-failing-tests-main branch January 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants