Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdistribute when students don't accept courses #16

Closed
betatim opened this issue Dec 4, 2018 · 2 comments · Fixed by #21
Closed

nbdistribute when students don't accept courses #16

betatim opened this issue Dec 4, 2018 · 2 comments · Fixed by #21

Comments

@betatim
Copy link
Collaborator

betatim commented Dec 4, 2018

When fetching student repositories fail with a useful error message when the student repo does not exist.

@lwasser
Copy link

lwasser commented Dec 4, 2018

The output below is for Jenny as she has yet to accept my new invite. This could happen as sometimes i may have new students who add the course late. Or maybe one is sick week one. Can this fail gracefully but still find the student once they accept and update with a PR?

Also this means that i have to know when i a student hasn't yet accepted because i'll have ot run nbdistribute again for them. Is there a way to have something run periodically that checks to see who hasn't yet accepted the invite? or some way to manage this? maybe too complex for the time being but just a note.

Fetching work for jlpalomino...
Traceback (most recent call last):
  File "/Users/leah-su/anaconda3/envs/earth-analytics-python/bin/nbdistribute", line 11, in <module>
    sys.exit(distribute())
  File "/Users/leah-su/anaconda3/envs/earth-analytics-python/lib/python3.6/site-packages/grading/__main__.py", line 144, in distribute
    token=config['github']['token'])
  File "/Users/leah-su/anaconda3/envs/earth-analytics-python/lib/python3.6/site-packages/grading/github.py", line 36, in fetch_student
    stdout=subprocess.PIPE, stderr=subprocess.PIPE)
  File "/Users/leah-su/anaconda3/envs/earth-analytics-python/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'clone', 'https://58060d2213243b43fd2f707735da1217a951fcaa@github.com/earth-analytics-edu/ea-spring-2019-jlpalomino.git']' returned non-zero exit status 128.

@betatim
Copy link
Collaborator Author

betatim commented Dec 5, 2018

Is there a way to have something run periodically that checks to see who hasn't yet accepted the invite? or some way to manage this?

We could build an extra tool to run that shows you if a student on the list in config.yml has a repository or not (aka accepted the invite). Alternatively, does GitHub classroom tell you? If it does that could be the v1 solution and we build a CLI tool for v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants