Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and testing + ci, code cov, black #68

Merged
merged 26 commits into from
Sep 21, 2019
Merged

Add docs and testing + ci, code cov, black #68

merged 26 commits into from
Sep 21, 2019

Conversation

lwasser
Copy link

@lwasser lwasser commented Sep 20, 2019

This should enable make docs -B to work properly. it's hard to run make when there is no makefile as it turns out :)

This also

  1. runs black on all modules
  2. adds titles to all modules for autodoc to work
  3. cleans up a few spacing issues that was blocking autodoc from working properly
  4. implements travis running make docs to align with local testing

@lwasser
Copy link
Author

lwasser commented Sep 20, 2019

this PR turned into a monster. it's close

============================ no tests ran in 0.10s =============================

ERROR: InvocationError for command /home/travis/build/earthlab/abc-classroom/.tox/py36/bin/pytest -v --basetemp=/home/travis/build/earthlab/abc-classroom/.tox/py36/tmp --cov=abcclassroom (exited with code 5)

___________________________________ summary ____________________________________

ERROR:   py36: commands failed

The command "./.travis/test.sh" exited with 1.

these commands run locally so something is not configured correctly in travis. i'm not sure if this is related to the web hook not connecting properly or something else...

@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f0af938). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #68   +/-   ##
======================================
  Coverage          ?   50%           
======================================
  Files             ?     2           
  Lines             ?    26           
  Branches          ?     0           
======================================
  Hits              ?    13           
  Misses            ?    13           
  Partials          ?     0
Impacted Files Coverage Δ
abcclassroom/distribute.py 35% <0%> (ø)
abcclassroom/tests/test_distribute.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0af938...bd62ec2. Read the comment docs.

@lwasser lwasser changed the title Add local build of docs using make Add docs and testing + ci, code cov, black Sep 21, 2019
@lwasser lwasser merged commit 6c61efe into master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant