Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnails #407

Merged
merged 6 commits into from Aug 29, 2019
Merged

Fix thumbnails #407

merged 6 commits into from Aug 29, 2019

Conversation

nkorinek
Copy link
Member

Fixed the two vignettes that still had messed up thumbnails so that they actually point to a plot.

@nkorinek
Copy link
Member Author

@lwasser this failed for a weird reason, I've never seen this error before: error: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\easy_install-98pagxyi\\munch-2.3.2\\munch\\__init__.py' Command exited with code 1 Have you seen this before? Any advice? I didn't change almost anything at all, except the numbers for the vignette gallerys, so I don't think it was my code.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #407   +/-   ##
======================================
  Coverage    94.9%   94.9%           
======================================
  Files          25      25           
  Lines        1629    1629           
======================================
  Hits         1546    1546           
  Misses         83      83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c348e...c28e9dc. Read the comment docs.

@lwasser
Copy link

lwasser commented Aug 23, 2019

@nkorinek sometimes appveyor is weird. i just rebuild it and it's all good!! you didn't do a thing. i've seen this before and i can't explain what happens. perhaps a file that is only isn't accessible at the moment it is trying to build??

@lwasser
Copy link

lwasser commented Aug 23, 2019

this closes #407 fix thumbnails on vignettes! thank you @nkorinek !!

@lwasser lwasser closed this Aug 23, 2019
@lwasser lwasser reopened this Aug 29, 2019
@lwasser
Copy link

lwasser commented Aug 29, 2019

addresses : #381

@lwasser lwasser merged commit 0bc074c into earthlab:master Aug 29, 2019
nkorinek added a commit to nkorinek/earthpy that referenced this pull request Aug 29, 2019
Fixed the last two vignettes so that their thumbnails work. (earthlab#407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants