Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the docs + examples of plot_bands #652

Merged
merged 2 commits into from Feb 4, 2021

Conversation

FaranIdo
Copy link
Contributor

Description

(1) The functions plot_rgb and _plot_image in plot.py had incorrect docstring for the parameter scale (default value is False).
(2) The example of "Turn On Scaling" in plot_bands_functionality.py didn't actually turn on scaling.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Executed plot_bands_functionality.py locally (inside virtualenv), verified that the pixels in the matplotlib output of Turn On Scaling in the range of 0..255

Checklist:

  • I have already submitted an issue and it was approved for a pr by an earthpy maintainer
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Base automatically changed from master to main February 1, 2021 23:49
@lwasser
Copy link

lwasser commented Feb 4, 2021

hi there @FaranIdo thank you for this pr!! we just updated our CI - if you can update this PR from main, i believe all tests should pass.

@FaranIdo
Copy link
Contributor Author

FaranIdo commented Feb 4, 2021

@lwasser fixed :)

@lwasser
Copy link

lwasser commented Feb 4, 2021

@FaranIdo awesome!! thank you again for the PR fix!! we truly appreciate it! 🙏

@lwasser lwasser merged commit 1ec2527 into earthlab:main Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants