Fix buildkit pauses at the end of builds #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsam
approved these changes
Jul 21, 2023
|
Is this safe to merge with these failing checks? Or are those just always failing? |
These checks will always fail, but we do at least need to create a PR to bump the buildkit version in earthly core to get the core tests to run against this code. I can put one together. |
|
a nitpicky request: can you manually squash your commits before merging this (and once you've done that, you can also do a fast-forward merge via the cli). |
dchw
force-pushed
the
corey/fix-buildkit-delays
branch
from
0461e94
to
45f84ad
Compare
dchw
force-pushed
the
corey/fix-buildkit-delays
branch
from
45f84ad
to
2b7fc7d
Compare
alexcb
approved these changes
Jul 25, 2023
dchw
added a commit
to earthly/earthly
that referenced
this pull request
Jul 26, 2023
This tests, and implements earthly/buildkit#20 as a partial performance resolution to #3085. Some of the higher resource utilization at the end exists (per user reports testing this fix), but the pauses appear to be gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the provenance feature does some hard-coded, extensive caching at the end of a build, regardless of if you use the sbom or provenance features.
This option appears to be un-bypassable, and is hard coded. Change it to
minto avoid the cache delays at the ends of builds.I've attached a profile. Anecdotally, I have seen some targets that went from ~40s runtime to ~10m runtime on
v0.7.4go back to their expected durations with this fix. No other immediately apparent reprercussions were seen... but admittedly my testing was not extensive.