-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roadmap #9
Comments
I think we should experiment language server protocol. Since it land, we can make emacs support by configuring lsp-mode to recognize it and solve missing feature in the editor ecosystem such as this issue vscode (earthly/earthly#507) or even vim. |
Yeah, I'm planning to work on the LSP soon with @vladaionescu . We just need to find some time in our schedules. New startup here, not a lot of OSS time left 😅 |
@TheCoreMan i’ve start explore the lsp on the previous week. The server can start and it connected to the lsp-mode but no any action implement yet. I can share the code to get this thing up. 😃 btw, congrats with your new startup. 😊 |
There's someone I'm talking to offline who is also experimenting with LSP over the next couple of weeks. No concrete plan yet though. It would be great if the roadmap was consolidated on this project. @TheCoreMan, I'll give you permissions on this repo to manage issues & projects, in case you wanted to populate that here. |
I've done some research on the language server a couple wees ago here. In the research, I use the library called jrpc2, it is JSON Rpc library that can parse LSP protocol header. And use a protocol that is generated from (use-package earthfile-mode
:init
(setq lsp-server-trace "verbose")
:config
(add-to-list 'lsp-language-id-configuration '(earthly-mode . "earthly"))
(lsp-register-client
(make-lsp-client :new-connection (lsp-stdio-connection "path/to/earthlyls")
:major-modes '(earthly-mode)
:language-id "earthly"
:server-id 'earthlyls
:priority 0))
(add-hook 'earthly-mode-hook #'lsp)) |
@vladaionescu waiting on the permission to create a project and then I'll populate the issues. @wingyplus awesome work on the LS :) Exactly what I wanted to start doing. This is probably a good reference https://github.com/golang/tools/blob/master/internal/lsp/server.go |
@TheCoreMan Yeah. That is the one I use and another one is terraform-ls, I use terraform-ls as a jsonrpc2 library reference. :) |
BTW @andrewsykim has also played around with LSP and came up with a basic implementation here: https://github.com/andrewsykim/earthly-lsp |
@TheCoreMan - the invite has already been sent. See https://github.com/earthly/earthly-emacs/invitations to accept. |
That’s really great!! I will find the time to integrating with the lsp. |
@TheCoreMan @vladaionescu Do you still have a backlog in the roadmap? |
First of all Hi everyone, cool seeing my initial random extension in MELPA! Great work all around.
In my original https://github.com/TheCoreMan/earthly-spacemacs-layer#plan repo, I had a roadmap with some cool features we should add. I think we should add that here as well, either in "Projects", or a file, or issues...? @vladaionescu How do you want to manage the backlog here? Up to you mostly :)
The text was updated successfully, but these errors were encountered: