Allow defaultGitImage to be a configurable value

[jschnitter]

We are testing earthly behind our corporate firewall that has no Internet access. We use artifactory as a pull through docker cache.

I am unable to use artifactory as a proper pull through cache because authentication details are not passed to docker, apparently because of this issue.

As an alternative to having an nginx frontend that can handle the authentication to our registry cache, I am hoping you'd be willing to allow the defaultGitImage to be an image that could be defined in ~/.earthly/config.yml.

I was able to verify git operations in earthly behind our firewall by building my own earthly docker image, changing the defaultGitImage in buildcontent/git.go to point to the same image in our artifactory instance, but would love to see this in the core earthly docker image so I don't have to build custom images from source.

Thanks for your consideration.

[alexcb]

That's awesome to hear you were able to rebuild it and it worked.

We'll accept a PR for such a feature; then once it's fixed upstream we could evaluate if it's still needed.

The gitImage could be moved into the gitResolver struct

earthly/buildcontext/git.go

Line 34 in fd5029a

type gitResolver struct {

which gets created via

earthly/buildcontext/resolver.go

Line 59 in fd5029a

gr: &gitResolver{

the NewResolver(...) function could be modified to take the gitImage string

earthly/builder/builder.go

Line 122 in fd5029a

b.resolver = buildcontext.NewResolver(opt.SessionID, opt.CleanCollection, opt.GitLookup, opt.Console, opt.FeatureFlagOverrides)

would have to be updated to pass the value in

earthly/builder/builder.go

Line 52 in fd5029a

type Opt struct {

would have to have a similar GitImage string added to it.

it gets set via

earthly/cmd/earthly/build_cmd.go

Line 389 in fd5029a

builderOpts := builder.Opt{

then finally a new ~/.earthly/config.yml option could be set under

earthly/config/config.go

Line 59 in fd5029a

type GlobalConfig struct {

which would then show up under build_cmd.go under app.cfg.GitImage.

I'll gladly help out if you run into any roadblocks along the way.

[jschnitter]

@alexcb -- I appreciate the detailed guide. Thank you. I'd be happy to take this on.

[hojerst]

this should be fixed/implemented now. (see above PR)