Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support #1013

Merged
merged 10 commits into from
May 28, 2021
Merged

Add TLS support #1013

merged 10 commits into from
May 28, 2021

Conversation

dchw
Copy link
Collaborator

@dchw dchw commented May 27, 2021

Added the TLS support, Can be controlled independently of the TCP setting.

@dchw dchw requested review from vladaionescu and alexcb May 27, 2021 18:20
vladaionescu
vladaionescu approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - I like the decoupling from the TCP connectivity.

@dchw dchw merged commit 7abaeb2 into main May 28, 2021
@dchw dchw deleted the corey/allow-tls branch May 28, 2021 15:33
@andrewsykim andrewsykim mentioned this pull request Nov 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladaionescu vladaionescu vladaionescu approved these changes

@alexcb alexcb Awaiting requested review from alexcb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dchw @vladaionescu