Fix prefixing for control character progress bars #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the handling of control characters which are used to display progress bars which use the \r control character.
vladaionescu
approved these changes
Jul 10, 2020
conslogging/conslogging.go
Outdated
| cl.w.Write(line) | ||
| cl.w.Write([]byte("\n")) | ||
|
|
||
| output := []byte{} |
There was a problem hiding this comment.
Should we do something like this here?
Suggested change
| output := []byte{} | |
| output := make([]byte, 0, len(data)) |
... or what would be a better guess of the capacity?
There was a problem hiding this comment.
good plan, i'll make that change.
conslogging/conslogging.go
Outdated
| } | ||
| } | ||
| if len(output) > 0 { | ||
| cl.w.Write(output) | ||
| output = []byte{} |
There was a problem hiding this comment.
I think this line makes the inefassign linter complain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of control characters which are used to display
progress bars which use the \r control character.