Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FOR ... IN ... #1142

Merged
merged 7 commits into from Aug 6, 2021
Merged

Implement FOR ... IN ... #1142

merged 7 commits into from Aug 6, 2021

Conversation

vladaionescu
Copy link
Member

@vladaionescu vladaionescu commented Aug 3, 2021

Part of #779

…LY, secrets, mounts. Need to test whether BUILD commands are parallel.
@vladaionescu vladaionescu marked this pull request as draft August 3, 2021 02:53
@vladaionescu vladaionescu requested a review from dchw August 5, 2021 21:17
@vladaionescu vladaionescu marked this pull request as ready for review August 5, 2021 21:17
Copy link
Collaborator

@dchw dchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wonder if we can use the SetArg stuff to also help overriding/re-setting build args?


test-for-comma:
RUN echo "foo,bar:buz:zub,oof" >./input.txt
FOR --sep="," what IN $(cat ./input.txt)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nervous that this turns into IFS someday

@vladaionescu
Copy link
Member Author

Wonder if we can use the SetArg stuff to also help overriding/re-setting build args?

Yes, it should. We just need to think about the semantics carefully.

@vladaionescu vladaionescu merged commit cd8cf8e into main Aug 6, 2021
@vladaionescu vladaionescu deleted the vlad/for-impl branch August 6, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants