Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit amount of status percentage that is output #143

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented Jul 24, 2020

only output percentage every 5 seconds or when it finishes, this avoids
the issue of lots of stdout being written.

Additionally display failed commands in red, and avoid showing too much
of context canceled errors which are a side effect of the main failure
(and can confuse users).

only output percentage every 5 seconds or when it finishes, this avoids
the issue of lots of stdout being written.

Additionally display failed commands in red, and avoid showing too much
of context canceled errors which are a side effect of the main failure
(and can confuse users).
@vladaionescu
Copy link
Member

Looks good - I've been playing with adding this to our integration tests:

Screenshot from 2020-07-24 18-50-33

The error definitely stands out more than before, though it's quite a few scrolls from the end.

I'm wondering also if we should repeat the output of the failed target at the end to make it more clear to the user. Either that, or have another separate command (eg earth last-failed or earth lf for short) whereby earth prints back the output of the last failure. What do you think?

Also, at the end, there's still a cryptic message like this Error: solve side effects: build error group: solve: failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c /bin/sh -c 'sleep 10; false']: buildkit-runc did not terminate successfully. Maybe we want something a bit more informative, where it says which target failed and which command (without the /bin/sh -c wrappers)?

Anyway... these are thoughts for a separate PR.

@alexcb alexcb marked this pull request as ready for review July 27, 2020 16:29
@alexcb alexcb merged commit f3450a1 into master Jul 27, 2020
@alexcb alexcb deleted the limit-status-percentage-output branch July 27, 2020 16:29
@abennett abennett mentioned this pull request Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants