Update crypto to address "parse error in message type 27" errors #2152
Conversation
This resolves errors stemming from golang/go#51689
|
Also, for my future reference... do you consider it a "rule" to have an Issue filed prior to submitting a PR (at least from external contributors)? I was going to create this PR only, but at the last minute, thought you might want/require a matching Issue. If it could/should be omitted for trivial changes like this, I'll gladly comply. |
rogue PRs (without a corresponding issue) are fine :) thanks for the update. |
|
Sweet, thanks! It looks like 4/5 of those failures are the Hub 'EOF' issue mentioned in Slack earlier. The fifth is a little obtuse to my untrained eye, but blinding assuming/hoping it's the same underlying issue. I'll assume there's nothing for me to do at this point until those are re-run. |
|
I'll try to get this released this week, thanks again for the fix. |
|
This was released today (slightly later than anticipated) |
This (re)-fixes #2151 After upgrading to 0.6.26 I started getting those errors again. It appears that 0382399 is the cause. The commit message/content doesn't indicate it was intentional. The downgrade happens to be the exact version that I upgraded from, which makes me think maybe it was a result of something like a weird merge conflict resolution, external automation, etc. Under the assumption it was not intentional, this is just the exact same fix from #2152.
Fixes #2151
This resolves errors stemming from golang/go#51689; it just so happens it was fixed a few hours ago. I didn't think a dependency change of this nature would warrant any new tests, but correct me if I'm wrong. But this does eliminate the errors after applying this change.