Add builtin support for git author timestamps #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
requested changes
Nov 30, 2022
There was a problem hiding this comment.
this is awesome, thanks for the contribution!
Can you create a new feature flag for this? that way users will have to explicitly enable it via VERSION --git-commit-author-timestamp 0.6
that way if an Earthfile depends on this feature, and a user is using an old version of earthly, the user will get an error such as "unknown feature-flag git-commit-author-timestamp" rather than have the ARG set to "".
Check out this commit (in particular the addition to features/features.go) to see how we've done this for previous newly introduced ARGs:
e20c10483#diff-a8b6135d50534471326ea7bcd20e0f5eae25353f7788338060f718128a6a0b34R30
alexcb
reviewed
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2432.
Add
EARTHLY_GIT_COMMIT_AUTHOR_TIMESTAMP, which points to the git author timestamp.